Rocket.Chat icon indicating copy to clipboard operation
Rocket.Chat copied to clipboard

fix: #34034 Fixed Push Notification Gateway

Open arth-1 opened this issue 1 year ago • 3 comments

Fixed sendNotification function to ensure proper asynchronous execution by removing unnecessary return. Improved error handling and logging to ensure reliable push notifications without affecting the flow of the application

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

arth-1 avatar Nov 22 '24 16:11 arth-1

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is missing the 'stat: QA assured' label
  • This PR is missing the required milestone or project

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

dionisio-bot[bot] avatar Nov 22 '24 16:11 dionisio-bot[bot]

⚠️ No Changeset found

Latest commit: 765068948f9400758111464ed6b4ace50b5e138c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

changeset-bot[bot] avatar Nov 22 '24 16:11 changeset-bot[bot]

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Nov 22 '24 16:11 CLAassistant