Cannot Set Bio to Empty
Description:
I would like to delete the Bio settings from my profile. When I delete all the Bio input and click save, a success notification appears. However, the Bio is not actually deleted and remains there. Is this by design, or is it a bug?
Steps to reproduce:
- Enter bio and save it.
- Delete all entries in bio and save.
- Check the profile.
Expected behavior:
bio should be empty.
Actual behavior:
The data from Step 1 remains in bio.
Server Setup Information:
- Version of Rocket.Chat Server: 6.13.0
- License Type:Starter
- Number of Users: 2
- Operating System: Rocky Linux 9.2
- Deployment Method: docker
- Number of Running Instances: 1
- DB Replicaset Oplog: true
- NodeJS Version: 14.21.3
- MongoDB Version:6.0.14
Client Setup Information
- Browser Version: Google Chrome 130.0.6723.60
- Operating System:Windows11
Additional context
Relevant logs:
When saving the bio with an empty field, no output appeared in the server logs. However, the following log was displayed in the browser console.
verifyErrors.js:34 Device Management is disabled on unsecure contexts, see https://developer.mozilla.org/en-US/docs/Web/Security/Secure_Contexts/features_restricted_to_secure_contexts
I would like to work on the issue
@akshat99812 Are you still working on this ? Or Can i work on it?
If anyone is not working on this I would like to work on the issue
Nice to see the PR curious-goblin; there were some changes requested. let us know when good for a new review =)
Thank you for the feedback. I have made all the requested changes and believe everything is addressed now. Please let me know if there’s anything else to adjust. Looking forward to your review.
Hi @casalsgh , I hope you're doing well! I wanted to kindly follow up on this PR as I’ve addressed all the requested changes and it’s ready for another review. Please let me know if there’s anything else I should adjust or update. Thanks for your time! 😊
Hey @Curious-Goblin I was working on the pr
Hi @akshat99812, since it’s been over a month without a PR for this issue and there was no active progress visible, so I thought that it would be a good issue to start with. My PR is now ready and addresses the problem along with tests. If you have any additional suggestions or ideas, I’d be happy to collaborate further.
Curious-Goblin, asked internal teams for a new review.
Thanks for checking on it
Hi @casalsgh,
I wanted to follow up on this issue since I haven’t been able to resolve a challenge related to it, and I hope someone can help.
I’ve created a new test file to validate the behavior of the saveUserProfile method, specifically for testing updates with an empty bio field. Initially, I mistakenly started writing the test in the wrong file (saveUserIdentity tests), but I corrected that by creating a dedicated test file for saveUserProfile.
However, I’m facing an issue where the test is not being picked up during execution. I also updated the .mocharc.js file to include the test file path, but the tests still don’t run as expected. I’ve tried running it directly and verifying the configuration, but without success.
Could you kindly take a look and guide me on how to ensure this new test file is executed? Your input would be greatly appreciated!
Thanks in advance!
Hi @casalsgh , I wanted to follow up on this PR #33927 since it's been over a week without a response. Please let me know if any further changes or clarifications are needed from my side to move this forward. I’m happy to address any feedback.
Hi @casalsgh ,
Don't '@' people please. It is not necessary.
I wanted to follow up on this PR #33927 since it's been over a week without a response. Please let me know if any further changes or clarifications are needed from my side to move this forward. I’m happy to address any feedback.
Again: Please note. Nothing around here happens fast. It can take MONTHS. There have also been the Christmas holidays which for many is up to two weeks and has only just finished. It is with the team. You just have to be extremely patient.
This has been tagged as 'Tasked'. it is in the internal systems. Someone will get back to you in due course but it may be a very long time. Also note:
Could you kindly take a look and guide me on how to ensure this new test file is executed?
This is a bug tracker, not development support. You need these sort of issues pinned down before you ask for reviews - it will just delay things. For support questions ask on open
Ok, I will take care of these things next time