Rocket.Chat icon indicating copy to clipboard operation
Rocket.Chat copied to clipboard

UX: Idle Time Limit misses unit

Open LenzGr opened this issue 1 year ago • 16 comments

Description:

In the account preferences, there's an option to enable the "Auto Away" feature and an option to define an "Idle Time Limit". The text box provides no guidance about what unit this time limit is defined in. Based on the number (3600 in my case), a more technical user can probably deduct that the unit is seconds, but it would be helpful to provide some guidance here, at least by informing the user that the limit is defined in seconds, ideally by giving them a way to define the value in a more human-readable way (in hours, minutes, seconds).

Screenshot 2024-09-27 at 09 51 44

Steps to reproduce:

  1. Click your avatar icon
  2. Select "Preferences"
  3. Select "User Presence"
  4. Note the input field for "Idle Time Limit" showing a number without any units associated

Expected behavior:

The Idle Time Limit input field should indicate the unit used, or provide a more human-friendly way of selecting a time period.

Actual behavior:

The input fields does not provide any guidance of what to enter here.

Server Setup Information:

N/A (can't provide this information as a regular user on our platform)

Client Setup Information

  • Desktop App v4.1.1 on macOS

LenzGr avatar Oct 14 '24 15:10 LenzGr

Hello @LenzGr Is this what you are looking for? Screenshot from 2024-10-15 10-42-33

thepiyush-303 avatar Oct 15 '24 05:10 thepiyush-303

Hello @LenzGr Is this what you are looking for?

Thanks, @thepiyush-303 that would already be a step forward for sure! The icing on the cake would being able to use human-readable units here, e.g. using a time picker that allows me to choose hours, minutes and seconds...

LenzGr avatar Oct 15 '24 16:10 LenzGr

For sure, I'll have it ready by tomorrow!

thepiyush-303 avatar Oct 15 '24 16:10 thepiyush-303

@LenzGr I would like to work on this issue. Could I get this assigned?

ritankarsaha avatar Oct 16 '24 16:10 ritankarsaha

hey @ritankarsaha Currently I am working on it, I am new to the project that's why it's taking time but I have gained a lot of knowledge The feature will setup by adding input-fields calculating them and registering them with "IdleTimeLimit" paramater Thanks,

thepiyush-303 avatar Oct 16 '24 17:10 thepiyush-303

hey @ritankarsaha Currently I am working on it, I am new to the project that's why it's taking time but I have gained a lot of knowledge The feature will setup by adding input-fields calculating them and registering them with "IdleTimeLimit" paramater Thanks,

Sure @thepiyush-303 . I didn't realise you were still working on this issue. If u want to collaborate feel free to drop a ping. Thanks.

ritankarsaha avatar Oct 16 '24 21:10 ritankarsaha

Hey @ritankarsaha , I'd love to collaborate, but my schedule is a bit packed at the moment. I’ll definitely get back to you once things ease up a bit, and we can explore how to work together :)

thepiyush-303 avatar Oct 17 '24 16:10 thepiyush-303

Hey @ritankarsaha , I'd love to collaborate, but my schedule is a bit packed at the moment. I’ll definitely get back to you once things ease up a bit, and we can explore how to work together :)

Sure @thepiyush-303

ritankarsaha avatar Oct 17 '24 16:10 ritankarsaha

Hey @LenzGr , I've made requested changes, here's an image that highlights the updates. Screenshot from 2024-10-22 21-18-46 I also have generated PR #33708 on this changes

thepiyush-303 avatar Oct 22 '24 17:10 thepiyush-303

Hey @ritankarsaha , I've made requested changes, here's an image that highlights the updates. Screenshot from 2024-10-22 21-18-46 I also have generated PR #33708 on this changes

Ohh nice @thepiyush-303

ritankarsaha avatar Oct 23 '24 03:10 ritankarsaha

@thepiyush-303 Is this issue completely solved ?

ritankarsaha avatar Oct 26 '24 21:10 ritankarsaha

Hey @LenzGr , I've made requested changes, here's an image that highlights the updates. Screenshot from 2024-10-22 21-18-46 I also have generated PR #33708 on this changes

Looks good to me, thank you! From an end-user perspective, this is more intuitive.

LenzGr avatar Oct 28 '24 13:10 LenzGr

Please refer to #33708

This has not been finished and there is commentary on that PR by the team.

reetp avatar Nov 11 '24 12:11 reetp

Team, checking the issue with internal teams, from there will try to get a review on proposed PR.

casalsgh avatar Nov 11 '24 13:11 casalsgh

Sorry, there is already a PR proposed and got reviews. Changes requested, including a proposal for alternative solution. will keep an eye

casalsgh avatar Nov 11 '24 13:11 casalsgh

I have made requested changes per the alternate solution. #33708

thepiyush-303 avatar Dec 18 '24 11:12 thepiyush-303

Hey reetp,

Could you review the design and let me know if it looks good or if any changes are needed?

Image

thepiyush-303 avatar Feb 10 '25 16:02 thepiyush-303