Rocket.Chat icon indicating copy to clipboard operation
Rocket.Chat copied to clipboard

Multiple quotes do not add up to a singular blockquote if there are empty lines in between

Open TLINDEN opened this issue 1 year ago • 6 comments

Description:

If you want to quote a text consisting of multiple paragraphs (that is, sentences delimited by empty lines), the quoted lines do not add up into a singular quote. Rather the quoted empty line[s] shows the > character and it renders the whole thing as multiple separate quotes.

Steps to reproduce:

> I will not use abbrev.
> 
> I will not use abbrev.
> 
> I will not use abbrev.

I also tried to append a space to the bracket: > with the same result.

Expected behavior:

I'd rather expect to get a singular blockquote and no > characters shown.

Actual behavior:

The above example renders to:

bart

Server Setup Information:

  • Version of Rocket.Chat Server: 6.11.3
  • License Type: Community
  • Number of Users: 300
  • Operating System: Debian
  • Deployment Method: k8s
  • Number of Running Instances: 1
  • DB Replicaset Oplog: n/a
  • NodeJS Version: n/a
  • MongoDB Version: 5.0

Client Setup Information

  • Desktop App or Browser Version: chrome 116.0.5845.187
  • Operating System: Ubuntu 24.04

TLINDEN avatar Oct 08 '24 14:10 TLINDEN

Hey there ,

I would like to work on the issue.

Kan2003 avatar Nov 10 '24 12:11 Kan2003

This is a 'bug' but not sure whether it is fixable without side effects.

If people want to work on something then you can go straight ahead - issues are never assigned.

Ask questions on https://open.rocket.chat/channel/support

reetp avatar Nov 11 '24 12:11 reetp

I have referred it to the team but doubt it will get much attention.

reetp avatar Nov 11 '24 12:11 reetp

Team, this is a minor item for our list; if anyone wants to tackle and propose a solution. Please do and reference it here. In case we receive a PR I'll work to get a review for it.

thanks

casalsgh avatar Nov 11 '24 13:11 casalsgh

I have been working on this issue for a few days, and I found out that its solution lies in making changes to the grammar.pegjs file. But whenever I make valid changes to that file, the app crashes. would greatly appreciate your help.

thepiyush-303 avatar Nov 20 '24 12:11 thepiyush-303

This is not the place to be asking for coding/server help.

Please use the forums or https://open.rocket.chat for that.

reetp avatar Nov 20 '24 16:11 reetp

Raised a PR for it.

thepiyush-303 avatar Jan 28 '25 18:01 thepiyush-303

This issue has been nagging for a very long time, great to see a fix was proposed.

Any plans to merge/integrate?

RZA-SF avatar Sep 06 '25 19:09 RZA-SF