Rocket.Chat icon indicating copy to clipboard operation
Rocket.Chat copied to clipboard

chore: Add shebang line, -p flag to mkdir, and clean up unwanted characters in build.sh (#33123)

Open anoniz opened this issue 1 year ago • 2 comments

This PR addresses issue #33123 by making the following changes in Rocket.Chat/apps/meteor/packages/rocketchat-livechat/plugin/build.sh:

  • Added a shebang line (#!/bin/bash) at the beginning of the script to specify the shell to use.
  • Added the -p flag to the mkdir command to ensure parent directories are created if they do not exist.
  • Removed unwanted characters from the script to clean up the formatting.

Reproduction Steps:

To test these changes, execute the build.sh script from the following path in an environment where parent directories are not present:

Rocket.Chat/apps/meteor/packages/rocketchat-livechat/plugin/build.sh

These changes improve the script's portability and reliability, especially in environments where the required parent directories may not exist.

anoniz avatar Aug 24 '24 06:08 anoniz

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is missing the 'stat: QA assured' label
  • This PR is missing the required milestone or project

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

dionisio-bot[bot] avatar Aug 24 '24 06:08 dionisio-bot[bot]

⚠️ No Changeset found

Latest commit: 5c367009bf3bd593f42535a4b47f495e41361c6c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

changeset-bot[bot] avatar Aug 24 '24 06:08 changeset-bot[bot]

anyone can tell how i get "QA assured label on this?" its not merging... also I am not able to open the PR Guide link..it says "you are blocked..."

anoniz avatar Sep 17 '24 12:09 anoniz

@reetp

anyone can tell how i get "QA assured label on this?" its not merging... also I am not able to open the PR Guide link..it says "you are blocked..."

@reetp I am new on this..

anoniz avatar Sep 20 '24 18:09 anoniz

Please don't @ thanks. It gets realky annoying. I get all the notifications.

It is up to the team at this point. Nothing you can do.

reetp avatar Sep 20 '24 19:09 reetp

oh sorry. will never do that again.. thanks

On Sat, Sep 21, 2024 at 12:07 AM John Crisp @.***> wrote:

Please don't @ thanks. It gets realky annoying. I get all the notifications.

It is up to the team at this point. Nothing you can do.

— Reply to this email directly, view it on GitHub https://github.com/RocketChat/Rocket.Chat/pull/33144#issuecomment-2364358157, or unsubscribe https://github.com/notifications/unsubscribe-auth/APJNA7WZ4VQO2MYDEVUAFPTZXRW7FAVCNFSM6AAAAABNBJRIJ6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGNRUGM2TQMJVG4 . You are receiving this because you authored the thread.Message ID: @.***>

anoniz avatar Sep 20 '24 19:09 anoniz