Rocket.Chat icon indicating copy to clipboard operation
Rocket.Chat copied to clipboard

chore: Add shebang line, -p flag to mkdir, and clean up unwanted characters in build.sh

Open anoniz opened this issue 1 year ago • 7 comments

Description:

Summary: The build.sh script in the Rocket.Chat/apps/meteor/packages/rocketchat-livechat/plugin/ directory is missing a shebang line and fails to create directories correctly due to the absence of the -p flag with the mkdir command. Additionally, the script contains some unwanted characters that could be cleaned up.

Steps to Reproduce:

  1. Navigate to Rocket.Chat/apps/meteor/packages/rocketchat-livechat/plugin/.
  2. Run the build.sh script without specifying the shell explicitly.
  3. Observe the errors related to directory creation and the script's execution.

Expected Behavior:

  • The script should include a shebang line for proper execution.
  • The mkdir command should use the -p flag to ensure parent directories are created if they do not exist.
  • The script should execute without errors and create the necessary directories.

Actual Behavior:

  • The script fails to run properly due to the missing shebang line.
  • The mkdir command does not create directories as expected because the -p flag is missing.
  • The script contains unwanted characters or formatting issues.

File Path: Rocket.Chat/apps/meteor/packages/rocketchat-livechat/plugin/build.sh

Additional Information:

  • Meteor Version: 2.16 (provided for context)

anoniz avatar Aug 22 '24 10:08 anoniz

Thanks for reporting this.

It would be great if you could create a PR and we can ask the devs to take a look.

reetp avatar Aug 22 '24 11:08 reetp

yeah sure,, i have solved the issue. making PR soon

anoniz avatar Aug 23 '24 05:08 anoniz

@reetp Hi, I have made a PR, have a look.

anoniz avatar Aug 24 '24 06:08 anoniz

No need @ anyone thanks.

I read it all when I get time.

I'll refer this to the team.

reetp avatar Aug 24 '24 09:08 reetp

ok, thanks

anoniz avatar Aug 24 '24 13:08 anoniz

This is in the queue for review but may take a while.

reetp avatar Aug 28 '24 07:08 reetp

ok, thanks for letting me know

anoniz avatar Aug 28 '24 09:08 anoniz