chore: Add shebang line, -p flag to mkdir, and clean up unwanted characters in build.sh
Description:
Summary:
The build.sh script in the Rocket.Chat/apps/meteor/packages/rocketchat-livechat/plugin/ directory is missing a shebang line and fails to create directories correctly due to the absence of the -p flag with the mkdir command. Additionally, the script contains some unwanted characters that could be cleaned up.
Steps to Reproduce:
- Navigate to
Rocket.Chat/apps/meteor/packages/rocketchat-livechat/plugin/. - Run the
build.shscript without specifying the shell explicitly. - Observe the errors related to directory creation and the script's execution.
Expected Behavior:
- The script should include a shebang line for proper execution.
- The
mkdircommand should use the-pflag to ensure parent directories are created if they do not exist. - The script should execute without errors and create the necessary directories.
Actual Behavior:
- The script fails to run properly due to the missing shebang line.
- The
mkdircommand does not create directories as expected because the-pflag is missing. - The script contains unwanted characters or formatting issues.
File Path:
Rocket.Chat/apps/meteor/packages/rocketchat-livechat/plugin/build.sh
Additional Information:
- Meteor Version: 2.16 (provided for context)
Thanks for reporting this.
It would be great if you could create a PR and we can ask the devs to take a look.
yeah sure,, i have solved the issue. making PR soon
@reetp Hi, I have made a PR, have a look.
No need @ anyone thanks.
I read it all when I get time.
I'll refer this to the team.
ok, thanks
This is in the queue for review but may take a while.
ok, thanks for letting me know