Rocket.Chat icon indicating copy to clipboard operation
Rocket.Chat copied to clipboard

fix: use correct setting object for cache when not actually overwritten

Open debdutdeb opened this issue 1 year ago • 2 comments

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

debdutdeb avatar Jul 08 '24 12:07 debdutdeb

🦋 Changeset detected

Latest commit: 8931608864f814d52d3f2823ba55513d4ff96a71

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 32 packages
Name Type
@rocket.chat/meteor Minor
@rocket.chat/core-typings Minor
@rocket.chat/rest-typings Minor
@rocket.chat/apps Patch
@rocket.chat/core-services Patch
@rocket.chat/cron Patch
@rocket.chat/fuselage-ui-kit Major
@rocket.chat/gazzodown Major
@rocket.chat/livechat Patch
@rocket.chat/model-typings Patch
@rocket.chat/ui-contexts Major
@rocket.chat/account-service Patch
@rocket.chat/authorization-service Patch
@rocket.chat/ddp-streamer Patch
@rocket.chat/omnichannel-transcript Patch
@rocket.chat/presence-service Patch
@rocket.chat/queue-worker Patch
@rocket.chat/stream-hub-service Patch
@rocket.chat/api-client Patch
@rocket.chat/license Patch
@rocket.chat/omnichannel-services Patch
@rocket.chat/pdf-worker Patch
@rocket.chat/presence Patch
rocketchat-services Patch
@rocket.chat/ddp-client Patch
@rocket.chat/uikit-playground Patch
@rocket.chat/models Patch
@rocket.chat/ui-avatar Major
@rocket.chat/ui-client Major
@rocket.chat/ui-video-conf Major
@rocket.chat/web-ui-registration Major
@rocket.chat/instance-status Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

changeset-bot[bot] avatar Jul 08 '24 12:07 changeset-bot[bot]

Looks like this PR is ready to merge! 🎉 If you have any trouble, please check the PR guidelines

dionisio-bot[bot] avatar Jul 08 '24 12:07 dionisio-bot[bot]

Codecov Report

Attention: Patch coverage is 70.58824% with 5 lines in your changes missing coverage. Please review.

Project coverage is 55.54%. Comparing base (47819cd) to head (8931608). Report is 5 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop   #32742   +/-   ##
========================================
  Coverage    55.54%   55.54%           
========================================
  Files         2634     2634           
  Lines        57248    57274   +26     
  Branches     11853    11864   +11     
========================================
+ Hits         31797    31815   +18     
- Misses       22757    22760    +3     
- Partials      2694     2699    +5     
Flag Coverage Δ
e2e 54.28% <ø> (+<0.01%) :arrow_up:
unit 72.27% <70.58%> (+0.19%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

codecov[bot] avatar Jul 12 '24 14:07 codecov[bot]

@ggazzo @KevLehman https://github.com/RocketChat/Rocket.Chat/pull/32814

debdutdeb avatar Jul 17 '24 14:07 debdutdeb