feat: replicate IPreRoomUserLeave and IPostRoomUserLeave event in meteor method and add removedBy to IRoomUserLeaveContext
Proposed changes (including videos or screenshots)
Issue(s)
CORE-498 Depends on https://github.com/RocketChat/Rocket.Chat.Apps-engine/pull/779
Steps to test or reproduce
Further comments
🦋 Changeset detected
Latest commit: 0cfa318ee63672475c3f055aa533fdb3dcc9d0f3
The changes in this PR will be included in the next version bump.
This PR includes changesets to release 32 packages
| Name | Type |
|---|---|
| @rocket.chat/meteor | Minor |
| @rocket.chat/core-typings | Minor |
| @rocket.chat/rest-typings | Minor |
| @rocket.chat/apps | Patch |
| @rocket.chat/core-services | Patch |
| @rocket.chat/cron | Patch |
| @rocket.chat/fuselage-ui-kit | Major |
| @rocket.chat/gazzodown | Major |
| @rocket.chat/livechat | Patch |
| @rocket.chat/model-typings | Patch |
| @rocket.chat/ui-contexts | Major |
| @rocket.chat/account-service | Patch |
| @rocket.chat/authorization-service | Patch |
| @rocket.chat/ddp-streamer | Patch |
| @rocket.chat/omnichannel-transcript | Patch |
| @rocket.chat/presence-service | Patch |
| @rocket.chat/queue-worker | Patch |
| @rocket.chat/stream-hub-service | Patch |
| @rocket.chat/api-client | Patch |
| @rocket.chat/license | Patch |
| @rocket.chat/omnichannel-services | Patch |
| @rocket.chat/pdf-worker | Patch |
| @rocket.chat/presence | Patch |
| rocketchat-services | Patch |
| @rocket.chat/ddp-client | Patch |
| @rocket.chat/uikit-playground | Patch |
| @rocket.chat/models | Patch |
| @rocket.chat/ui-avatar | Major |
| @rocket.chat/ui-client | Major |
| @rocket.chat/ui-video-conf | Major |
| @rocket.chat/web-ui-registration | Major |
| @rocket.chat/instance-status | Patch |
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
Looks like this PR is ready to merge! 🎉 If you have any trouble, please check the PR guidelines
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 55.49%. Comparing base (
25da528) to head (0cfa318).
Additional details and impacted files
@@ Coverage Diff @@
## develop #32724 +/- ##
===========================================
- Coverage 55.53% 55.49% -0.04%
===========================================
Files 2632 2632
Lines 57175 57174 -1
Branches 11842 11841 -1
===========================================
- Hits 31751 31728 -23
- Misses 22737 22759 +22
Partials 2687 2687
| Flag | Coverage Δ | |
|---|---|---|
| e2e | 54.24% <ø> (-0.07%) |
:arrow_down: |
| unit | 72.05% <ø> (-0.02%) |
:arrow_down: |
Flags with carried forward coverage won't be shown. Click here to find out more.
This doesn't strictly require the PR on the Apps-Engine side, it will trigger the event in the new place and send the new context, even if the app won't get to see the info yet. We can treat those as separate (it does not need to wait for the new alpha version of the apps-engine and then update)