Rocket.Chat icon indicating copy to clipboard operation
Rocket.Chat copied to clipboard

feat: Added Creation Date col in Rooms Table in Admin Panel.

Open heet434 opened this issue 1 year ago • 6 comments

Proposed changes (including videos or screenshots)

Added a column that displays the room creation date. Screenshot 2024-07-02 at 2 16 14 PM

Also added a ts field to retrieve the creation date from the database.

Issue(s)

Here's the link: https://github.com/RocketChat/feature-requests/issues/893

Steps to test or reproduce

Open the Rooms section in Admin Panel. Need for a creation date column there.

Further comments

heet434 avatar Jul 02 '24 08:07 heet434

🦋 Changeset detected

Latest commit: 3099a9b718b198d0d9a8678c0a872ff0a461512c

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

changeset-bot[bot] avatar Jul 02 '24 08:07 changeset-bot[bot]

Hi @hugocostadev , I have resolved the typecheck and lint errors, and used the useFormatDate function for formatting the date, but I can't find out as to what exactly is failing the unit test in @rocket.chat/license:testunit . Could you please help me out here?

heet434 avatar Jul 02 '24 16:07 heet434

Hi @hugocostadev , I have resolved the typecheck and lint errors, and used the useFormatDate function for formatting the date, but I can't find out as to what exactly is failing the unit test in @rocket.chat/license:testunit . Could you please help me out here?

Hey @heet434 I'll review it again! Thanks!

Related to the unit test, don't worry... it's expected, we are going to fix this internally

hugocostadev avatar Jul 02 '24 16:07 hugocostadev

Hi @hugocostadev , I have resolved the typecheck and lint errors, and used the useFormatDate function for formatting the date, but I can't find out as to what exactly is failing the unit test in @rocket.chat/license:testunit . Could you please help me out here?

Hey @heet434 I'll review it again! Thanks!

Related to the unit test, don't worry... it's expected, we are going to fix this internally

@hugocostadev Thank you! I'll add the commits that resolve the prev issue.

heet434 avatar Jul 02 '24 16:07 heet434

Looks like this PR is ready to merge! 🎉 If you have any trouble, please check the PR guidelines

dionisio-bot[bot] avatar Jul 03 '24 14:07 dionisio-bot[bot]

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 59.39%. Comparing base (77989f5) to head (b3fd334). Report is 13 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #32709      +/-   ##
===========================================
- Coverage    59.40%   59.39%   -0.01%     
===========================================
  Files         2541     2541              
  Lines        63180    63172       -8     
  Branches     14221    14218       -3     
===========================================
- Hits         37530    37524       -6     
+ Misses       22935    22934       -1     
+ Partials      2715     2714       -1     

codecov[bot] avatar Jul 04 '24 16:07 codecov[bot]