Rocket.Chat icon indicating copy to clipboard operation
Rocket.Chat copied to clipboard

regression(E2EEncryption): Fix PDF preview & download not working on electron/desktop app

Open rodrigok opened this issue 1 year ago • 3 comments

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

rodrigok avatar Jun 28 '24 12:06 rodrigok

Looks like this PR is ready to merge! 🎉 If you have any trouble, please check the PR guidelines

dionisio-bot[bot] avatar Jun 28 '24 12:06 dionisio-bot[bot]

⚠️ No Changeset found

Latest commit: ad9de519a4289ddbea03c07c47e9cdfc472a71c8

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

changeset-bot[bot] avatar Jun 28 '24 12:06 changeset-bot[bot]

Codecov Report

Attention: Patch coverage is 28.00000% with 18 lines in your changes missing coverage. Please review.

Please upload report for BASE (release-6.10.0@c6add10). Learn more about missing BASE report.

Additional details and impacted files

Impacted file tree graph

@@                Coverage Diff                @@
##             release-6.10.0   #32698   +/-   ##
=================================================
  Coverage                  ?   56.69%           
=================================================
  Files                     ?     2497           
  Lines                     ?    55391           
  Branches                  ?    11461           
=================================================
  Hits                      ?    31403           
  Misses                    ?    21281           
  Partials                  ?     2707           
Flag Coverage Δ
e2e 56.41% <28.00%> (?)
unit 71.85% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

codecov[bot] avatar Jun 28 '24 12:06 codecov[bot]