chore!: Remove API_Use_REST_For_DDP_Calls setting
https://rocketchat.atlassian.net/browse/CORE-497
Proposed changes (including videos or screenshots)
Issue(s)
Steps to test or reproduce
Further comments
with the removal of most meteor methods, I don't see any particular reason to keep this setting around. This is a must for ms deployments anyway, no harm is just making it the only reality.
Looks like this PR is not ready to merge, because of the following issues:
- This PR is missing the 'stat: QA assured' label
- This PR is missing the required milestone or project
Please fix the issues and try again
If you have any trouble, please check the PR guidelines
🦋 Changeset detected
Latest commit: d157d726daf38cb80968ab2131e5d5feecb2a582
The changes in this PR will be included in the next version bump.
This PR includes changesets to release 32 packages
| Name | Type |
|---|---|
| @rocket.chat/meteor | Major |
| @rocket.chat/core-typings | Major |
| @rocket.chat/rest-typings | Major |
| @rocket.chat/apps | Patch |
| @rocket.chat/core-services | Patch |
| @rocket.chat/cron | Patch |
| @rocket.chat/fuselage-ui-kit | Major |
| @rocket.chat/gazzodown | Major |
| @rocket.chat/livechat | Patch |
| @rocket.chat/model-typings | Patch |
| @rocket.chat/ui-contexts | Major |
| @rocket.chat/account-service | Patch |
| @rocket.chat/authorization-service | Patch |
| @rocket.chat/ddp-streamer | Patch |
| @rocket.chat/omnichannel-transcript | Patch |
| @rocket.chat/presence-service | Patch |
| @rocket.chat/queue-worker | Patch |
| @rocket.chat/stream-hub-service | Patch |
| @rocket.chat/api-client | Patch |
| @rocket.chat/license | Patch |
| @rocket.chat/omnichannel-services | Patch |
| @rocket.chat/pdf-worker | Patch |
| @rocket.chat/presence | Patch |
| rocketchat-services | Patch |
| @rocket.chat/ddp-client | Patch |
| @rocket.chat/uikit-playground | Patch |
| @rocket.chat/models | Patch |
| @rocket.chat/ui-avatar | Major |
| @rocket.chat/ui-client | Major |
| @rocket.chat/ui-video-conf | Major |
| @rocket.chat/web-ui-registration | Major |
| @rocket.chat/instance-status | Patch |
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 56.34%. Comparing base (
3d74b63) to head (d157d72). Report is 590 commits behind head on release-7.0.0.
Additional details and impacted files
@@ Coverage Diff @@
## release-7.0.0 #32590 +/- ##
=================================================
- Coverage 56.35% 56.34% -0.02%
=================================================
Files 2437 2437
Lines 53824 53809 -15
Branches 11101 11096 -5
=================================================
- Hits 30331 30317 -14
- Misses 20847 20877 +30
+ Partials 2646 2615 -31
| Flag | Coverage Δ | |
|---|---|---|
| unit | 71.89% <ø> (+0.09%) |
:arrow_up: |
Flags with carried forward coverage won't be shown. Click here to find out more.