Rocket.Chat icon indicating copy to clipboard operation
Rocket.Chat copied to clipboard

feat: verify federation configuration before processing any events

Open debdutdeb opened this issue 1 year ago • 3 comments

https://rocketchat.atlassian.net/browse/CORE-479 https://rocketchat.atlassian.net/browse/CORE-518 https://rocketchat.atlassian.net/browse/CORE-524

Proposed changes (including videos or screenshots)

We need to verify homeserver <> appservice connection, which is achieved by https://spec.matrix.org/v1.10/application-service-api/#pinging

Also if rocketchat itself is ready for federation or not, using https://federationtester.matrix.org/

Issue(s)

Steps to test or reproduce

Further comments

image

debdutdeb avatar Jun 01 '24 09:06 debdutdeb

Looks like this PR is ready to merge! 🎉 If you have any trouble, please check the PR guidelines

dionisio-bot[bot] avatar Jun 01 '24 09:06 dionisio-bot[bot]

🦋 Changeset detected

Latest commit: 72e606dafb356c2cb668584aa1a3cfd2481e5776

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 32 packages
Name Type
@rocket.chat/meteor Minor
@rocket.chat/core-typings Minor
@rocket.chat/rest-typings Minor
@rocket.chat/api-client Patch
@rocket.chat/apps Patch
@rocket.chat/core-services Patch
@rocket.chat/cron Patch
@rocket.chat/ddp-client Patch
@rocket.chat/fuselage-ui-kit Major
@rocket.chat/gazzodown Major
@rocket.chat/livechat Patch
@rocket.chat/model-typings Patch
@rocket.chat/ui-contexts Major
@rocket.chat/account-service Patch
@rocket.chat/authorization-service Patch
@rocket.chat/ddp-streamer Patch
@rocket.chat/omnichannel-transcript Patch
@rocket.chat/presence-service Patch
@rocket.chat/queue-worker Patch
@rocket.chat/stream-hub-service Patch
@rocket.chat/license Patch
@rocket.chat/omnichannel-services Patch
@rocket.chat/pdf-worker Patch
@rocket.chat/presence Patch
rocketchat-services Patch
@rocket.chat/uikit-playground Patch
@rocket.chat/models Patch
@rocket.chat/ui-avatar Major
@rocket.chat/ui-client Major
@rocket.chat/ui-video-conf Major
@rocket.chat/web-ui-registration Major
@rocket.chat/instance-status Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

changeset-bot[bot] avatar Jun 01 '24 09:06 changeset-bot[bot]

Codecov Report

Attention: Patch coverage is 80.95238% with 20 lines in your changes missing coverage. Please review.

Project coverage is 59.43%. Comparing base (6cb79a0) to head (72e606d). Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #32535      +/-   ##
===========================================
- Coverage    59.44%   59.43%   -0.01%     
===========================================
  Files         2544     2546       +2     
  Lines        63239    63255      +16     
  Branches     14235    14235              
===========================================
+ Hits         37590    37594       +4     
- Misses       22930    22941      +11     
- Partials      2719     2720       +1     
Flag Coverage Δ
unit 76.02% <80.95%> (-0.08%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

codecov[bot] avatar Jun 01 '24 09:06 codecov[bot]