Rocket.Chat icon indicating copy to clipboard operation
Rocket.Chat copied to clipboard

fix: Livechat allowing file upload when setting is false

Open MartinSchoeler opened this issue 1 year ago • 2 comments

SUP-457

MartinSchoeler avatar Feb 15 '24 19:02 MartinSchoeler

🦋 Changeset detected

Latest commit: 5421c75f616d899647ae41f78d73908fc27aa36f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 32 packages
Name Type
@rocket.chat/meteor Patch
@rocket.chat/livechat Patch
@rocket.chat/core-typings Patch
@rocket.chat/rest-typings Patch
@rocket.chat/apps Patch
@rocket.chat/core-services Patch
@rocket.chat/cron Patch
@rocket.chat/gazzodown Patch
@rocket.chat/model-typings Patch
@rocket.chat/ui-contexts Patch
@rocket.chat/account-service Patch
@rocket.chat/authorization-service Patch
@rocket.chat/ddp-streamer Patch
@rocket.chat/omnichannel-transcript Patch
@rocket.chat/presence-service Patch
@rocket.chat/queue-worker Patch
@rocket.chat/stream-hub-service Patch
@rocket.chat/api-client Patch
@rocket.chat/license Patch
@rocket.chat/omnichannel-services Patch
@rocket.chat/pdf-worker Patch
@rocket.chat/presence Patch
rocketchat-services Patch
@rocket.chat/ddp-client Patch
@rocket.chat/fuselage-ui-kit Patch
@rocket.chat/models Patch
@rocket.chat/ui-avatar Patch
@rocket.chat/ui-client Patch
@rocket.chat/ui-video-conf Patch
@rocket.chat/uikit-playground Patch
@rocket.chat/web-ui-registration Patch
@rocket.chat/instance-status Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

changeset-bot[bot] avatar Feb 15 '24 19:02 changeset-bot[bot]

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 54.93%. Comparing base (e373bc1) to head (5421c75).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop   #31765   +/-   ##
========================================
  Coverage    54.93%   54.93%           
========================================
  Files         2306     2304    -2     
  Lines        50912    50886   -26     
  Branches     10417    10411    -6     
========================================
- Hits         27967    27954   -13     
+ Misses       20434    20433    -1     
+ Partials      2511     2499   -12     
Flag Coverage Δ
e2e 53.98% <ø> (+0.01%) :arrow_up:
unit 75.43% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

codecov[bot] avatar Feb 15 '24 19:02 codecov[bot]

A UI test would also be great :)

KevLehman avatar Mar 18 '24 14:03 KevLehman

A UI test would also be great :)

E2E UI tests will be done in a subsequent PR. Task: https://rocketchat.atlassian.net/browse/CORE-216

MarcosSpessatto avatar Mar 22 '24 13:03 MarcosSpessatto

Looks like this PR is ready to merge! 🎉 If you have any trouble, please check the PR guidelines

dionisio-bot[bot] avatar Apr 03 '24 16:04 dionisio-bot[bot]

This PR currently has a merge conflict. Please resolve this and then re-add the ['stat: ready to merge', 'automerge'] label.

kodiakhq[bot] avatar Apr 05 '24 16:04 kodiakhq[bot]