fix: Considering the auto join channels inside teams
Proposed changes (including videos or screenshots)
Earlier, whenever we had auto join teams, when the user joined, we would not look at the auto-join channels inside of it. The idea is, that when we are going to create the subscriptions between the team and the user, we check whether the team has a default channel, if so, fetch those and add the user to it as well
Issue(s)
Steps to test or reproduce
- Convert the general room into a team
- Create a new channel inside the general team
- Set the new channel as auto-join
- Create a new user
Expected Behavior: The user should be added to both the team and the channel Current behavior: The user is being added only to the team
Further comments
CORE-58
🦋 Changeset detected
Latest commit: 91980e21fb82f50d50ceb43735494051f1472fbd
The changes in this PR will be included in the next version bump.
This PR includes changesets to release 31 packages
| Name | Type |
|---|---|
| @rocket.chat/meteor | Patch |
| @rocket.chat/core-typings | Patch |
| @rocket.chat/rest-typings | Patch |
| @rocket.chat/apps | Patch |
| @rocket.chat/core-services | Patch |
| @rocket.chat/cron | Patch |
| @rocket.chat/gazzodown | Patch |
| @rocket.chat/livechat | Patch |
| @rocket.chat/model-typings | Patch |
| @rocket.chat/ui-contexts | Patch |
| @rocket.chat/account-service | Patch |
| @rocket.chat/authorization-service | Patch |
| @rocket.chat/ddp-streamer | Patch |
| @rocket.chat/omnichannel-transcript | Patch |
| @rocket.chat/presence-service | Patch |
| @rocket.chat/queue-worker | Patch |
| @rocket.chat/stream-hub-service | Patch |
| @rocket.chat/api-client | Patch |
| @rocket.chat/license | Patch |
| @rocket.chat/omnichannel-services | Patch |
| @rocket.chat/pdf-worker | Patch |
| @rocket.chat/presence | Patch |
| rocketchat-services | Patch |
| @rocket.chat/ddp-client | Patch |
| @rocket.chat/fuselage-ui-kit | Patch |
| @rocket.chat/models | Patch |
| @rocket.chat/ui-client | Patch |
| @rocket.chat/ui-video-conf | Patch |
| @rocket.chat/uikit-playground | Patch |
| @rocket.chat/web-ui-registration | Patch |
| @rocket.chat/instance-status | Patch |
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 54.57%. Comparing base (
b0aace7) to head (91980e2).
Additional details and impacted files
@@ Coverage Diff @@
## develop #31720 +/- ##
===========================================
- Coverage 54.61% 54.57% -0.05%
===========================================
Files 2283 2283
Lines 50279 50279
Branches 10255 10255
===========================================
- Hits 27461 27439 -22
- Misses 20331 20351 +20
- Partials 2487 2489 +2
| Flag | Coverage Δ | |
|---|---|---|
| e2e | 53.54% <ø> (-0.02%) |
:arrow_down: |
| e2e-api | 40.00% <ø> (-0.11%) |
:arrow_down: |
| unit | 76.44% <ø> (ø) |
Flags with carried forward coverage won't be shown. Click here to find out more.