fix: Correct display of discussion names in sidebar search

[abhinavkrin]

Proposed changes (including videos or screenshots)

This fix alters the spotlight search endpoint method to include the prid (parent room ID) for rooms. This adjustment ensures that the client correctly identifies discussions and displays their names instead of IDs in the sidebar search results. This change resolves the issue where discussion IDs were displayed when the "Allow Special Characters in Room Names" setting was disabled, aligning the behavior with the search results when the setting is enabled.

Issue(s)

Fixes issue where discussion names were incorrectly displayed as IDs in sidebar search results under specific conditions.

Steps to test or reproduce

1. Disable "Allow Special Characters in Room Names".
2. Create a discussion inside a public channel.
3. Search for the discussion by name in the sidebar with a different user account.

Further comments

SUP-410

[changeset-bot[bot]]

🦋 Changeset detected

Latest commit: 832cdf6b18e12da9ba832da2f7093ce0cde04643

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 30 packages

Name	Type
@rocket.chat/meteor	Patch
@rocket.chat/core-typings	Patch
@rocket.chat/rest-typings	Patch
@rocket.chat/core-services	Patch
@rocket.chat/cron	Patch
@rocket.chat/gazzodown	Patch
@rocket.chat/livechat	Patch
@rocket.chat/model-typings	Patch
@rocket.chat/ui-contexts	Patch
@rocket.chat/account-service	Patch
@rocket.chat/authorization-service	Patch
@rocket.chat/ddp-streamer	Patch
@rocket.chat/omnichannel-transcript	Patch
@rocket.chat/presence-service	Patch
@rocket.chat/queue-worker	Patch
@rocket.chat/stream-hub-service	Patch
@rocket.chat/api-client	Patch
@rocket.chat/license	Patch
@rocket.chat/omnichannel-services	Patch
@rocket.chat/pdf-worker	Patch
@rocket.chat/presence	Patch
rocketchat-services	Patch
@rocket.chat/ddp-client	Patch
@rocket.chat/fuselage-ui-kit	Patch
@rocket.chat/models	Patch
@rocket.chat/ui-client	Patch
@rocket.chat/ui-video-conf	Patch
@rocket.chat/uikit-playground	Patch
@rocket.chat/web-ui-registration	Patch
@rocket.chat/instance-status	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[codecov[bot]]

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (f8e6801) 54.52% compared to head (832cdf6) 54.48%.

Additional details and impacted files

@@             Coverage Diff             @@
##           develop   #31701      +/-   ##
===========================================
- Coverage    54.52%   54.48%   -0.05%     
===========================================
  Files         2272     2271       -1     
  Lines        50103    50089      -14     
  Branches     10219    10219              
===========================================
- Hits         27321    27289      -32     
- Misses       20309    20327      +18     
  Partials      2473     2473              

Flag	Coverage Δ
e2e	53.43% <ø> (-0.03%)	:arrow_down:
e2e-api	39.86% <ø> (-0.09%)	:arrow_down:
unit	76.47% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

[abhinavkrin]

Can we add a test case to cover this scenario?

Hey @MarcosSpessatto I have added test for this scenario. It tests discussion search in both cases when UI_Allow_room_names_with_special_chars is true or false