Rocket.Chat icon indicating copy to clipboard operation
Rocket.Chat copied to clipboard

[NEW] Bypass Time limits permission

Open LucianoPierdona opened this issue 3 years ago • 1 comments

Proposed changes (including videos or screenshots)

This PR adds a new permission called bypass-time-limit-edit-and-delete, to bypass the time limit when editing or deleting a message, the purpose of this PR is to remove the limitation for bots that cannot change the message after the specified time.

Issue(s)

Steps to test or reproduce

  • Add a Jira integration with RC such that it creates threads in RC, and when the status of the Jira task is updated, the first message in the thread in RC gets updated via REST API to correspond to the Jira status.
  • In RC, go to Administration -> Message -> Block Message Editing After X Minutes and set the value to 10
  • Update the status of the Jira task after 10 minutes

Further comments

TC-329

LucianoPierdona avatar Dec 26 '22 19:12 LucianoPierdona

Codecov Report

Merging #27644 (9bc72d6) into develop (e86f1af) will increase coverage by 0.07%. The diff coverage is 57.14%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #27644      +/-   ##
===========================================
+ Coverage    41.60%   41.67%   +0.07%     
===========================================
  Files          849      849              
  Lines        17556    17560       +4     
  Branches      2087     2087              
===========================================
+ Hits          7305     7319      +14     
+ Misses        9979     9967      -12     
- Partials       272      274       +2     
Flag Coverage Δ
e2e 41.67% <57.14%> (+0.07%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

codecov[bot] avatar Dec 26 '22 20:12 codecov[bot]

wait that fix a lot! thank you!

ankar84 avatar Jan 07 '23 04:01 ankar84

This PR currently has a merge conflict. Please resolve this and then re-add the ['stat: ready to merge', 'automerge'] label.

kodiakhq[bot] avatar Feb 08 '23 16:02 kodiakhq[bot]

@hugocostadev could you review this again?

rodrigok avatar Feb 09 '23 11:02 rodrigok