Rocket.Chat icon indicating copy to clipboard operation
Rocket.Chat copied to clipboard

Chore: Update eslint-config package manifest

Open d-gubert opened this issue 2 years ago • 1 comments

Proposed changes (including videos or screenshots)

Updated the eslint-config package manifest to include dependencies instead of devDependencies - this way, when the package is installed in another project, dependencies are installed along with it. The way it is currently on develop, you have to run npm install manually for all dependencies if you want to use the package

Issue(s)

Steps to test or reproduce

Further comments

It might mess a bit with how yarn keeps things organized? Not sure if the impact is meaningful though

d-gubert avatar Dec 22 '22 22:12 d-gubert

Codecov Report

Merging #27619 (799e993) into develop (b06e962) will increase coverage by 19.55%. Report is 1 commits behind head on develop. The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##           develop   #27619       +/-   ##
============================================
+ Coverage    31.06%   50.62%   +19.55%     
============================================
  Files          560      754      +194     
  Lines        10808    14537     +3729     
  Branches      2007     2611      +604     
============================================
+ Hits          3358     7359     +4001     
+ Misses        7245     6787      -458     
- Partials       205      391      +186     
Flag Coverage Δ
e2e 47.78% <ø> (+16.72%) :arrow_up:
unit 68.53% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

codecov[bot] avatar Dec 23 '22 00:12 codecov[bot]

⚠️ No Changeset found

Latest commit: 799e99303e078d6258f646964f38108fe95d60f8

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

changeset-bot[bot] avatar Jun 14 '23 19:06 changeset-bot[bot]

This PR currently has a merge conflict. Please resolve this and then re-add the ['stat: ready to merge', 'automerge'] label.

kodiakhq[bot] avatar Jun 19 '23 18:06 kodiakhq[bot]