Rocket.Chat icon indicating copy to clipboard operation
Rocket.Chat copied to clipboard

[FIX] Allow federated rooms with the same name per servers

Open MarcosSpessatto opened this issue 2 years ago • 1 comments

Proposed changes (including videos or screenshots)

The main purpose for this PR is to allow the room creation with the same name, but from different servers, for example: room1 from matrix.org room1 from my-matrix.server room1 from my-matrix2.server ...

We are still enforcing to have only one room with a specific name per server, for example: room1 from my-local-server.com room1 from my-local-server.com <= This is not allowed.

Issue(s)

Steps to test or reproduce

Further comments

MarcosSpessatto avatar Dec 15 '22 18:12 MarcosSpessatto

Codecov Report

:exclamation: No coverage uploaded for pull request base (feat/federation-feat-2@5c34c33). Click here to learn what that means. The diff coverage is n/a.

:exclamation: Current head 602953f differs from pull request most recent head 9e727f6. Consider uploading reports for the commit 9e727f6 to get more accurate results

Impacted file tree graph

@@                    Coverage Diff                    @@
##             feat/federation-feat-2   #27559   +/-   ##
=========================================================
  Coverage                          ?   41.85%           
=========================================================
  Files                             ?      845           
  Lines                             ?    17817           
  Branches                          ?     2024           
=========================================================
  Hits                              ?     7457           
  Misses                            ?    10092           
  Partials                          ?      268           
Flag Coverage Δ
e2e 41.85% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

codecov[bot] avatar Dec 16 '22 20:12 codecov[bot]