Rocket.Chat icon indicating copy to clipboard operation
Rocket.Chat copied to clipboard

[IMPROVE] Require acceptance when setting new E2E Encryption key for another user

Open rodrigok opened this issue 3 years ago • 1 comments

Proposed changes (including videos or screenshots)

Change the end to end encryption flow to require an acceptance from the user when receiving a new key.

  1. Changes API e2e.updateGroupKey to set the new key to an auxiliary property named E2ESuggestedKey
  2. Adds new API e2e.acceptSuggestedGroupKey to be called to accept the suggested key and save it to the final property E2EKey
  3. Adds new API e2e.rejectSuggestedGroupKey to be called to reject the suggested key and clear the E2ESuggestedKey

Issue(s)

Steps to test or reproduce

Further comments

rodrigok avatar Dec 15 '22 18:12 rodrigok

Codecov Report

Merging #27556 (9ea3da7) into develop (0c53e9d) will increase coverage by 0.04%. The diff coverage is 33.33%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #27556      +/-   ##
===========================================
+ Coverage    41.97%   42.01%   +0.04%     
===========================================
  Files          841      841              
  Lines        17706    17716      +10     
  Branches      1996     1998       +2     
===========================================
+ Hits          7432     7444      +12     
  Misses       10016    10016              
+ Partials       258      256       -2     
Flag Coverage Δ
e2e 42.01% <33.33%> (+0.04%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

codecov[bot] avatar Dec 15 '22 19:12 codecov[bot]