Rocket.Chat
Rocket.Chat copied to clipboard
[IMPROVE] Require acceptance when setting new E2E Encryption key for another user
Proposed changes (including videos or screenshots)
Change the end to end encryption flow to require an acceptance from the user when receiving a new key.
- Changes API
e2e.updateGroupKeyto set the new key to an auxiliary property namedE2ESuggestedKey - Adds new API
e2e.acceptSuggestedGroupKeyto be called to accept the suggested key and save it to the final propertyE2EKey - Adds new API
e2e.rejectSuggestedGroupKeyto be called to reject the suggested key and clear theE2ESuggestedKey
Issue(s)
Steps to test or reproduce
Further comments
Codecov Report
Merging #27556 (9ea3da7) into develop (0c53e9d) will increase coverage by
0.04%. The diff coverage is33.33%.
@@ Coverage Diff @@
## develop #27556 +/- ##
===========================================
+ Coverage 41.97% 42.01% +0.04%
===========================================
Files 841 841
Lines 17706 17716 +10
Branches 1996 1998 +2
===========================================
+ Hits 7432 7444 +12
Misses 10016 10016
+ Partials 258 256 -2
| Flag | Coverage Δ | |
|---|---|---|
| e2e | 42.01% <33.33%> (+0.04%) |
:arrow_up: |
Flags with carried forward coverage won't be shown. Click here to find out more.