Rocket.Chat icon indicating copy to clipboard operation
Rocket.Chat copied to clipboard

[BREAK] Freeze Custom Roles

Open LucianoPierdona opened this issue 2 years ago • 1 comments

Proposed changes (including videos or screenshots)

This PR moves role creation and update to enterprise folder

--

  • Deprecated method authorization:saveRole
  • Moved /v1/roles.create/ and /v1/roles.update to enterprise edition
  • Changed message for delete a custom role in community edition

Issue(s)

Steps to test or reproduce

Further comments

TC-282

LucianoPierdona avatar Dec 07 '22 14:12 LucianoPierdona

Codecov Report

Merging #27481 (8013652) into develop (cdc2f99) will increase coverage by 1.02%. The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #27481      +/-   ##
===========================================
+ Coverage    40.94%   41.97%   +1.02%     
===========================================
  Files          838      847       +9     
  Lines        17677    17550     -127     
  Branches      1983     2078      +95     
===========================================
+ Hits          7238     7366     +128     
+ Misses       10201     9904     -297     
- Partials       238      280      +42     
Flag Coverage Δ
e2e 41.97% <100.00%> (+1.02%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

codecov[bot] avatar Dec 08 '22 14:12 codecov[bot]

@LucianoPierdona great PR. Just need to adjust the description since this removes the method rather than deprecating it

rodrigok avatar Feb 07 '23 18:02 rodrigok

@rodrigok @gabriellsh Are you seriously removing the whole permissions / roles management for all "free" users....?

danel1 avatar Feb 09 '23 11:02 danel1

Hi @danel1

From version 6.0 the Community Edition won't have the ability to create new Custom Roles. Existing Custom Roles will continue working but won't be able to be updated (change name or description), if deleted, they can't be recreated. So the effective change here is the movement of the API to create Custom Roles to the Enterprise Edition.

The ability to set permissions on native Roles, and the Custom Roles that already existed before the upgrade, will continue to be available in Community Edition.

In fact, the only change here is related to Custom Roles, not to the rest of the roles/permission system.

rodrigok avatar Feb 13 '23 18:02 rodrigok

This also breaks the option to enable or disable the Users must use Two Factor Authentication setting.

But sine that setting is broken anyway I guess who the fuck cares.

ulope avatar Apr 12 '23 14:04 ulope