Rocket.Chat icon indicating copy to clipboard operation
Rocket.Chat copied to clipboard

[FIX] Marketplace app status initially disabled

Open rique223 opened this issue 3 years ago • 1 comments

Proposed changes (including videos or screenshots)

Jira task: MKP-20

Currently, the only apps engine statuses considered enabled in the UI are the auto-enabled and manually-enabled statuses, this causes a UX problem in which the app will be considered disabled for the first few seconds of its lifecycle, upon the first installation in a workspace, since it will have the apps engine status of initialized. This PR adds the initialized status to the appEnabledStatuses list and solves this problem. Demo gif: disabled_status_issue_solution\

Issue(s)

Steps to test or reproduce

  1. Create a new workspace
  2. Open the admin section and select the apps option
  3. Install any app and pay attention to its status
  4. For good measure, reload the page and the status will probably change to enabled (Some apps won't because they are supposed to be disabled by default)

Further comments

rique223 avatar Nov 23 '22 21:11 rique223

Codecov Report

Merging #27330 (44c69ba) into develop (f5f5bf8) will increase coverage by 0.68%. The diff coverage is n/a.

:exclamation: Current head 44c69ba differs from pull request most recent head 7a8ec6d. Consider uploading reports for the commit 7a8ec6d to get more accurate results

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #27330      +/-   ##
===========================================
+ Coverage    41.31%   42.00%   +0.68%     
===========================================
  Files          841      810      -31     
  Lines        17706    17130     -576     
  Branches      1996     1909      -87     
===========================================
- Hits          7315     7195     -120     
+ Misses       10154     9695     -459     
- Partials       237      240       +3     
Flag Coverage Δ
e2e 42.00% <ø> (+0.68%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

codecov[bot] avatar Nov 23 '22 23:11 codecov[bot]