Rocket.Chat icon indicating copy to clipboard operation
Rocket.Chat copied to clipboard

[FIX] Remove unnecessary permissions check on app permissions review modal

Open rique223 opened this issue 3 years ago • 1 comments

Proposed changes (including videos or screenshots)

Jira task: MKP-166

Removed an unnecessary check that verified if the app permissions list was an array and threw an error if it wasn't. This check has become unnecessary ever since the app permission review modal changed to show a default list of permissions in case the app happened to not have one and that's what caused those "random" undefined toasts that showed every once in a while. Demo gif: undefined_toast

Issue(s)

Steps to test or reproduce

  1. Access the admin section and then the apps option
  2. Install any app that has a 27 item(as of this PR) list of permissions

Further comments

rique223 avatar Nov 23 '22 20:11 rique223

Codecov Report

Merging #27329 (b4b5d16) into develop (cdc2f99) will increase coverage by 1.30%. The diff coverage is n/a.

:exclamation: Current head b4b5d16 differs from pull request most recent head 1a1b125. Consider uploading reports for the commit 1a1b125 to get more accurate results

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #27329      +/-   ##
===========================================
+ Coverage    40.94%   42.25%   +1.30%     
===========================================
  Files          838      812      -26     
  Lines        17677    17735      +58     
  Branches      1983     1990       +7     
===========================================
+ Hits          7238     7494     +256     
+ Misses       10201     9953     -248     
- Partials       238      288      +50     
Flag Coverage Δ
e2e 42.25% <ø> (+1.30%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

codecov[bot] avatar Nov 24 '22 03:11 codecov[bot]