Rocket.Chat
Rocket.Chat copied to clipboard
[NEW] Unreads messages - Hackathon RocketGov idea
Proposed changes (including videos or screenshots)
This is an idea which implemented in 1 week through RocketGov Hackathon by Cognity Team ( @bkrith - Vassilis Kritharakis, @mnsifaki - Maria Ioanna Sifaki, @vatsilidis - Lampros Vatsilidis, @Svoronos - Svoronos Leivadaros, @daino92 - Dionisis Kalepanagos). Unread Messages Video demonstration
Added Unread messages section in sidebar. Now users will be able to navigate through all of their unreads rooms/messages and mark them as read.
To achieve that we need to make some changes in methods/endpoints.
- loadHistory and loadMessageHistory improved with an extra param(unreadOnly). With this param returns only the unread rooms.
- unreadMessages and Subscriptions improved to submit unread rooms with the sum of unreads messages in unread property. before unread rooms has no way to find the unread messages.
- Added new route /unreads.
- Added in v1/chat an existing endpoint v1/chat.getThreadMessages.
- Fixed a bug in methods for loadHistory. ls wanted number and after that string through drilling. Required as Date as it is also ts.
New section in sidebar (Unread messages):
Inactive
Active
Page will have all messages under respective rooms, with mark as read for each and for all rooms. Also will have an undo functionality if marked as read by mistake and a basic sorting.
After Mark as read action on specific room is available undo action.
No unreads
Issue(s)
Steps to test or reproduce
Further comments
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
4 out of 5 committers have signed the CLA.
:white_check_mark: debdutdeb
:white_check_mark: bkrith
:white_check_mark: mnsifaki
:white_check_mark: vatsilidis
:x: Lampros.Vatsilidis
Lampros.Vatsilidis seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.
This pull request introduces 3 alerts when merging bd874f6e14584c5421400cd0662326ae3c7be743 into d1384ef5cdfce2896b464771ab8f8b03d49a214e - view on LGTM.com
new alerts:
- 3 for Useless conditional
This pull request introduces 3 alerts when merging 7c180c06481f394af34b8027755d5df379b24350 into d1384ef5cdfce2896b464771ab8f8b03d49a214e - view on LGTM.com
new alerts:
- 3 for Useless conditional
This pull request introduces 3 alerts when merging f5537dcc4825a5e61fd2b0f71c2aea9d2c96e02b into d1384ef5cdfce2896b464771ab8f8b03d49a214e - view on LGTM.com
new alerts:
- 3 for Useless conditional
This pull request introduces 3 alerts when merging 59b47af2781274118c22f1b04e5e4163c644f16e into d1384ef5cdfce2896b464771ab8f8b03d49a214e - view on LGTM.com
new alerts:
- 3 for Useless conditional
This pull request introduces 1 alert when merging a75b9edd86af7dcefd2a7bdd858c62c53ae7641f into d1384ef5cdfce2896b464771ab8f8b03d49a214e - view on LGTM.com
new alerts:
- 1 for Useless conditional
When visual concept done, could you share it as a gif/video on description? I'm really curious on how it will work visually 👍🏻
When visual concept done, could you share it as a gif/video on description? I'm really curious on how it will work visually 👍🏻
Of course! We are so sorry.. we are finishing our presence in hackathon and forgot!
@tiagoevanp screenshots added and soon will be a video demonstration. There is a lot of space for improvements but I and my team believe it's very nice start to introduce this feature to users.
This pull request introduces 1 alert when merging a2851c4203ee2bcf40a459eeb14677c0b686c27b into ca29977236a40014c39100247722599ad5177e2b - view on LGTM.com
new alerts:
- 1 for Useless conditional
Heads-up: LGTM.com's PR analysis will be disabled on the 5th of December, and LGTM.com will be shut down ⏻ completely on the 16th of December 2022. Please enable GitHub code scanning, which uses the same CodeQL engine :gear: that powers LGTM.com. For more information, please check out our post on the GitHub blog.