[FIX] Failed login counter not reset after successful login

[LucianoPierdona]

Proposed changes (including videos or screenshots)

Issue(s)

Closes #26828

Steps to test or reproduce

• Enable failed log in block thing
• enter your password wrong the defined number of times
• wait for the defined number of minutes to be able to attempt again
• enter the wrong password again
• notice you're now blocked without trying x number of times as set in the setting.

Further comments

TC-183

[codecov[bot]]

Codecov Report

Merging #27212 (7b7852d) into develop (6eb8cec) will increase coverage by 15.13%. The diff coverage is n/a.

@@             Coverage Diff              @@
##           develop   #27212       +/-   ##
============================================
+ Coverage    49.06%   64.20%   +15.13%     
============================================
  Files          723       52      -671     
  Lines        14138     1341    -12797     
  Branches      2502      262     -2240     
============================================
- Hits          6937      861     -6076     
+ Misses        6813      426     -6387     
+ Partials       388       54      -334     

Flag	Coverage Δ
e2e	?
unit	64.20% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

[gabriellsh]

OOOPS! Requested changes on a previous commit 🙈 I'll review again

[debdutdeb]

Will check out this patch ASAP. Still travelling :) should be done in a couple hours. Thanks.

[loagencydev]

If this in anyway fixes the issue, then I believe it must also be merged pretty soon. we're locked out of our accounts, and even admin cannot log into the system

[kodiakhq[bot]]

This PR currently has a merge conflict. Please resolve this and then re-add the ['stat: ready to merge', 'automerge'] label.

[changeset-bot[bot]]

🦋 Changeset detected

Latest commit: 7b7852daabbf1e2204137ad4796a0922cecb6562

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 29 packages

Name	Type
@rocket.chat/meteor	Patch
@rocket.chat/core-typings	Patch
@rocket.chat/model-typings	Patch
@rocket.chat/core-services	Patch
@rocket.chat/cron	Patch
@rocket.chat/gazzodown	Patch
@rocket.chat/livechat	Patch
@rocket.chat/rest-typings	Patch
@rocket.chat/ui-contexts	Patch
@rocket.chat/account-service	Patch
@rocket.chat/authorization-service	Patch
@rocket.chat/ddp-streamer	Patch
@rocket.chat/omnichannel-transcript	Patch
@rocket.chat/presence-service	Patch
@rocket.chat/queue-worker	Patch
@rocket.chat/stream-hub-service	Patch
@rocket.chat/api-client	Patch
@rocket.chat/omnichannel-services	Patch
@rocket.chat/pdf-worker	Patch
@rocket.chat/presence	Patch
rocketchat-services	Patch
@rocket.chat/models	Patch
@rocket.chat/fuselage-ui-kit	Patch
@rocket.chat/ddp-client	Patch
@rocket.chat/ui-client	Patch
@rocket.chat/ui-video-conf	Patch
@rocket.chat/uikit-playground	Patch
@rocket.chat/web-ui-registration	Patch
@rocket.chat/instance-status	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[gabriellsh]

Closed in favor of #30018