Rocket.Chat icon indicating copy to clipboard operation
Rocket.Chat copied to clipboard

Chore: fix regressions for omnichannel due room refactor

Open ggazzo opened this issue 2 years ago • 1 comments

Error just after closing room and Room info no being opened

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

ggazzo avatar Sep 21 '22 16:09 ggazzo

Codecov Report

Merging #26912 (0338bf5) into develop (548d8e6) will decrease coverage by 0.00%. The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #26912      +/-   ##
===========================================
- Coverage    40.80%   40.79%   -0.01%     
===========================================
  Files          793      793              
  Lines        17851    17848       -3     
  Branches      1940     1941       +1     
===========================================
- Hits          7284     7281       -3     
+ Misses       10271    10268       -3     
- Partials       296      299       +3     
Flag Coverage Δ
e2e 40.79% <100.00%> (-0.01%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

codecov[bot] avatar Sep 21 '22 18:09 codecov[bot]

This pull request introduces 1 alert when merging 02b2025fdb383bd2fa952f2ea742617a19e511b9 into 6ae770b40da1318378ec5faed73e996e0e607358 - view on LGTM.com

new alerts:

  • 1 for Useless assignment to local variable

lgtm-com[bot] avatar Sep 22 '22 03:09 lgtm-com[bot]

Screen Shot 2022-09-22 at 1 49 13 PM

If you try to open a livechat that has been closed via current-chats the channel will appear empty

Okay, since the changes are already on develop, this issue is not locked to the scope of this PR, we can work out a fix in another PR

MartinSchoeler avatar Sep 22 '22 22:09 MartinSchoeler

This pull request introduces 1 alert when merging 0338bf55ce36834ebb2c2f806aab1b2176581dc8 into 548d8e6fbe8d57f0d4c92dbf0af867c5c6277c08 - view on LGTM.com

new alerts:

  • 1 for Useless assignment to local variable

lgtm-com[bot] avatar Sep 23 '22 00:09 lgtm-com[bot]