Rocket.Chat icon indicating copy to clipboard operation
Rocket.Chat copied to clipboard

Feature Request: Show Preferences when Accounts_AllowUserProfileChange is false

Open nmagedman opened this issue 3 years ago • 2 comments

Description:

PR #25632 (commit 813883181) shows the NotAuthorizedPage if Accounts_AllowUserProfileChange is false. This leads to an awkward user experience, as the user thinks he does not have access to any of his preferences:

Screen Shot 2022-09-19 at 14 30 27

A better UI/UX would be to redirect the user to the Preferences tab (the first visible tab in the navbar)

Steps to reproduce:

  1. As an admin, go to /admin/permissions
  2. Click on the Settings subtab in the main pane (not the one in the navbar)
  3. Type in "profile"
  4. Disable "Accounts > Allow User Profile Change" for all roles
  5. As a regular user, go to RocketChat (web version)
  6. Click on [Avatar menu] > My Account

Expected behavior:

Show a meaningful page about my account. This used to be the /account/profile page, which would at least show your profile even though you couldn't edit any of it. A more useful page however would be the /account/preferences page.

Actual behavior:

A page with the content "You are not authorized to view this page.", along with a left navbar of pages which do work, although the user is discouraged from clicking on them due to the formal, authoritarian error message.

Server Setup Information:

  • Version of Rocket.Chat Server: 5.1.2
  • Operating System: Linux
  • Deployment Method: tar
  • Number of Running Instances: 2
  • DB Replicaset Oplog: enabled
  • NodeJS Version: v14.19.3
  • MongoDB Version: 4.2.15

Client Setup Information

  • Desktop App or Browser Version: Chrome 105.0.5195.102
  • Operating System: MacOS

nmagedman avatar Sep 19 '22 12:09 nmagedman

Hi! Thanks for the suggestion!

dudanogueira avatar Sep 19 '22 12:09 dudanogueira

Can I take up this issue @dudanogueira @nmagedman ?

rksingh2001 avatar Sep 21 '22 07:09 rksingh2001

@debdutdeb Can you add the hacktoberfest label on this issue?

rksingh2001 avatar Oct 01 '22 11:10 rksingh2001

We'll start with the labels next week.

IIUC, this request needs to be assessed by product first.

debdutdeb avatar Oct 01 '22 14:10 debdutdeb