Rocket.Chat
Rocket.Chat copied to clipboard
[FIX] Email inbox memory leak on connection failure
OC-184
Proposed changes (including videos or screenshots)
- Properly removing event listeners on re-connection.
- Attachments handling changed from beforeMessageSent to afterMessageSent, as the id of the message was needed, now rocket.cat will send the "Send Attachment To Email" button.
- Self-disable email inbox when reaching max re-connection attempts
Issue(s)
Steps to test or reproduce
Further comments
Codecov Report
Merging #26850 (470b035) into develop (9d42405) will increase coverage by
0.45%. The diff coverage isn/a.
:exclamation: Current head 470b035 differs from pull request most recent head dae0e56. Consider uploading reports for the commit dae0e56 to get more accurate results
@@ Coverage Diff @@
## develop #26850 +/- ##
===========================================
+ Coverage 40.31% 40.76% +0.45%
===========================================
Files 827 802 -25
Lines 18258 17810 -448
Branches 2020 1961 -59
===========================================
- Hits 7360 7261 -99
+ Misses 10604 10255 -349
Partials 294 294
| Flag | Coverage Δ | |
|---|---|---|
| e2e | 40.76% <ø> (+0.45%) |
:arrow_up: |
Flags with carried forward coverage won't be shown. Click here to find out more.
OC-184
This pull request introduces 1 alert when merging 886be366e4f92bf8001b5292421b6317c80815fb into 30230229608a442ff63614cb92cb62df89bb3ec8 - view on LGTM.com
new alerts:
- 1 for Syntax error