Rocket.Chat icon indicating copy to clipboard operation
Rocket.Chat copied to clipboard

[FIX] Email inbox memory leak on connection failure

Open cauefcr opened this issue 3 years ago • 3 comments

OC-184

Proposed changes (including videos or screenshots)

  • Properly removing event listeners on re-connection.
  • Attachments handling changed from beforeMessageSent to afterMessageSent, as the id of the message was needed, now rocket.cat will send the "Send Attachment To Email" button.
  • Self-disable email inbox when reaching max re-connection attempts

Issue(s)

Steps to test or reproduce

Further comments

cauefcr avatar Sep 12 '22 13:09 cauefcr

Codecov Report

Merging #26850 (470b035) into develop (9d42405) will increase coverage by 0.45%. The diff coverage is n/a.

:exclamation: Current head 470b035 differs from pull request most recent head dae0e56. Consider uploading reports for the commit dae0e56 to get more accurate results

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #26850      +/-   ##
===========================================
+ Coverage    40.31%   40.76%   +0.45%     
===========================================
  Files          827      802      -25     
  Lines        18258    17810     -448     
  Branches      2020     1961      -59     
===========================================
- Hits          7360     7261      -99     
+ Misses       10604    10255     -349     
  Partials       294      294              
Flag Coverage Δ
e2e 40.76% <ø> (+0.45%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

codecov[bot] avatar Sep 12 '22 14:09 codecov[bot]

OC-184

cauefcr avatar Sep 13 '22 16:09 cauefcr

This pull request introduces 1 alert when merging 886be366e4f92bf8001b5292421b6317c80815fb into 30230229608a442ff63614cb92cb62df89bb3ec8 - view on LGTM.com

new alerts:

  • 1 for Syntax error

lgtm-com[bot] avatar Sep 20 '22 18:09 lgtm-com[bot]