Rocket.Chat icon indicating copy to clipboard operation
Rocket.Chat copied to clipboard

[IMPROVE] Livechat: Allow external attachments to be resolved

Open cauefcr opened this issue 3 years ago • 2 comments

OC-198

Proposed changes (including videos or screenshots)

Allow external urls to be viewed on livechat.

Issue(s)

issue#26511

Steps to test or reproduce

Further comments

Fixes botpress integration issue

cauefcr avatar Sep 08 '22 19:09 cauefcr

Codecov Report

Merging #26833 (3a2aefd) into develop (90fe2ed) will increase coverage by 0.55%. The diff coverage is n/a.

:exclamation: Current head 3a2aefd differs from pull request most recent head 28f3c45. Consider uploading reports for the commit 28f3c45 to get more accurate results

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #26833      +/-   ##
===========================================
+ Coverage    40.48%   41.04%   +0.55%     
===========================================
  Files          840      791      -49     
  Lines        18329    17809     -520     
  Branches      2052     1928     -124     
===========================================
- Hits          7421     7309     -112     
+ Misses       10622    10203     -419     
- Partials       286      297      +11     
Flag Coverage Δ
e2e 41.04% <ø> (+0.55%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

codecov[bot] avatar Sep 08 '22 20:09 codecov[bot]

  9 failed
    apps.spec.ts:29:2 › Apps › expect allow user open app contextualbar ============================
    homepage.spec.ts:64:6 › homepage › layout for regular users › cards › expect homepage-create-channels-card card to be visible 
    omnichannel-close-chat.spec.ts:42:2 › Omnichannel close chat › Receiving a message from visitor 
    omnichannel-contact-info.spec.ts:42:2 › Omnichannel contact info › Receiving a message from visitor, and seeing its information 
    omnichannel-custom-fields.spec.ts:16:2 › omnichannel-agents › expect add new "custom field" ====
    omnichannel-livechat.spec.ts:64:4 › Livechat › Send message from user › Verify message is received › expect message is received from user 
    omnichannel-livechat.spec.ts:101:4 › Livechat › Send message from user › Verify markdown message is received › expect message is received from user 
    omnichannel-manager.spec.ts:17:2 › omnichannel-manager › expect add "user1" as manager =========
    omnichannel-send-transcript.spec.ts:42:2 › omnichannel-transcript › Receiving a message from visitor 
  23 skipped
  80 passed (15m)

still missing these

cauefcr avatar Sep 09 '22 21:09 cauefcr