Rocket.Chat icon indicating copy to clipboard operation
Rocket.Chat copied to clipboard

[NEW] Matrix Federation events coverage expansion (support for 5 more events)

Open MarcosSpessatto opened this issue 2 years ago • 4 comments

Proposed changes (including videos or screenshots)

The goal of this PR is to add support for more events on Matrix Federation feature. The new supported events are:

  • Edit Messages;
  • Delete Messages
  • File Upload (including video and audio/voice messages);
  • Send emojis on messages;
  • Reactions.

Issue(s)

Steps to test or reproduce

Further comments

MarcosSpessatto avatar Aug 26 '22 17:08 MarcosSpessatto

This pull request introduces 2 alerts when merging 5cd888982aaee27f4c6c51ad6a4a989ed91c459f into 2155e04f7d3f1a53c09cd6dcaad8610c8982615c - view on LGTM.com

new alerts:

  • 2 for Unused variable, import, function or class

lgtm-com[bot] avatar Aug 26 '22 19:08 lgtm-com[bot]

Codecov Report

Merging #26705 (c59efe3) into develop (5d3a3d2) will decrease coverage by 0.18%. The diff coverage is 41.17%.

:exclamation: Current head c59efe3 differs from pull request most recent head 94002a9. Consider uploading reports for the commit 94002a9 to get more accurate results

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #26705      +/-   ##
===========================================
- Coverage    40.76%   40.58%   -0.19%     
===========================================
  Files          801      793       -8     
  Lines        17919    17851      -68     
  Branches      1958     1940      -18     
===========================================
- Hits          7305     7245      -60     
+ Misses       10319    10305      -14     
- Partials       295      301       +6     
Flag Coverage Δ
e2e 40.58% <41.17%> (-0.19%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

codecov[bot] avatar Aug 29 '22 15:08 codecov[bot]

may I ask to change the PR title? It currently doesn't have a meaningful explanation to be shown on the change log. Is it really a [NEW]? it doesn't describe what exactly is the NEW stuff

sampaiodiego avatar Sep 19 '22 20:09 sampaiodiego

may I ask to change the PR title? It currently doesn't have a meaningful explanation to be shown on the change log. Is it really a [NEW]? it doesn't describe what exactly is the NEW stuff

Yes, it adds 4 new features. Feel free to suggest any new title 😄

MarcosSpessatto avatar Sep 19 '22 20:09 MarcosSpessatto

This PR currently has a merge conflict. Please resolve this and then re-add the ['stat: ready to merge', 'automerge'] label.

kodiakhq[bot] avatar Sep 22 '22 17:09 kodiakhq[bot]

This PR currently has a merge conflict. Please resolve this and then re-add the ['stat: ready to merge', 'automerge'] label.

kodiakhq[bot] avatar Sep 23 '22 20:09 kodiakhq[bot]