Rocket.Chat
Rocket.Chat copied to clipboard
[IMPROVE] Read receipts in threads
Proposed changes (including videos or screenshots)
- Create new
afterReadThread
callback to handle read receipts for messages in threads; - Add read receipts for messages in threads only when the thread is open;
- Remove the read/unread checkmark for messages in threads.
Issue(s)
Steps to test or reproduce
- Go to Administration > Message and enable "Show Read Receipts" and "Detailed Read Receipts";
- Login with two users and access the same room with both of them;
- As "User 1", send a message in an existing thread;
- Access this room as "User 2". Expected behavior: the message sent in step 3 should NOT be marked as read by "User 2";
- As "User 2", send a message in the room (not in the thread). Expected behavior: the message sent in step 3 should still NOT be marked as read by "User 2";
- Open the thread as "User 2". Expected behavior: the message sent in step 3 should be marked as read by "User 2";
- Send a new message in the thread. Expected behavior: the new message should be instantly marked as read by both users.
Further comments
Codecov Report
Merging #26611 (141b07e) into develop (f53520f) will decrease coverage by
2.76%
. The diff coverage is0.00%
.
:exclamation: Current head 141b07e differs from pull request most recent head 591ce76. Consider uploading reports for the commit 591ce76 to get more accurate results
@@ Coverage Diff @@
## develop #26611 +/- ##
===========================================
- Coverage 41.20% 38.44% -2.77%
===========================================
Files 845 794 -51
Lines 18291 19005 +714
Branches 2078 1937 -141
===========================================
- Hits 7537 7306 -231
- Misses 10479 11406 +927
- Partials 275 293 +18
Flag | Coverage Δ | |
---|---|---|
e2e | 38.44% <0.00%> (-2.77%) |
:arrow_down: |
Flags with carried forward coverage won't be shown. Click here to find out more.
Let's hold this one for 6.0