Rocket.Chat icon indicating copy to clipboard operation
Rocket.Chat copied to clipboard

[FIX] Do not allow admin users edit other federated users

Open MarcosSpessatto opened this issue 2 years ago • 1 comments

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

I haven't added tests for this endpoint change since we don't have a way to create a federated user (unless set up the whole federation) and simulate the behavior.

MarcosSpessatto avatar Aug 09 '22 16:08 MarcosSpessatto

Codecov Report

Merging #26528 (35f74cb) into improve/federation-general-improvements (24ac9c4) will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@                           Coverage Diff                            @@
##           improve/federation-general-improvements   #26528   +/-   ##
========================================================================
  Coverage                                    38.07%   38.07%           
========================================================================
  Files                                          745      745           
  Lines                                        18625    18625           
  Branches                                      1412     1412           
========================================================================
  Hits                                          7091     7091           
+ Misses                                       11313    11310    -3     
- Partials                                       221      224    +3     
Flag Coverage Δ
e2e 38.07% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

codecov[bot] avatar Aug 09 '22 19:08 codecov[bot]