Rocket.Chat icon indicating copy to clipboard operation
Rocket.Chat copied to clipboard

Chore: Allow admin to access any groups info and members.

Open albuquerquefabio opened this issue 3 years ago • 4 comments

Proposed changes (including videos or screenshots)

This PR allows the admin to access any group info and members. But, the admin cannot access messages from groups that they not joining.

Issue(s)

Admins don't receive information about private rooms it is not a member of. https://github.com/RocketChat/Rocket.Chat/issues/15435

Steps to test or reproduce

Further comments

albuquerquefabio avatar Jul 29 '22 21:07 albuquerquefabio

This pull request introduces 2 alerts when merging 33e0adf1d6fa01ada2a0b9d0c62b1b2c47250114 into b11bab5e7e533309fd8d5bbe2493c0eb9a7f1bac - view on LGTM.com

new alerts:

  • 2 for Unused variable, import, function or class

lgtm-com[bot] avatar Jul 29 '22 21:07 lgtm-com[bot]

This pull request introduces 2 alerts when merging 939bb951c254d5c0f10f44b0a0226742c37e430f into e13d7d222d5e345f69687544f06c1e9f9f65905c - view on LGTM.com

new alerts:

  • 2 for Unused variable, import, function or class

lgtm-com[bot] avatar Aug 30 '22 17:08 lgtm-com[bot]

@albuquerquefabio can you describe better what this change does?

rodrigok avatar Nov 22 '22 13:11 rodrigok

Description updated.

albuquerquefabio avatar Dec 01 '22 13:12 albuquerquefabio

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 44.96%. Comparing base (8e5a3e9) to head (ce9a16f). Report is 2328 commits behind head on develop.

:exclamation: Current head ce9a16f differs from pull request most recent head 783274f. Consider uploading reports for the commit 783274f to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #26423      +/-   ##
===========================================
+ Coverage    44.94%   44.96%   +0.02%     
===========================================
  Files          753      753              
  Lines        14665    14665              
  Branches      2130     2130              
===========================================
+ Hits          6591     6594       +3     
+ Misses        7771     7767       -4     
- Partials       303      304       +1     
Flag Coverage Δ
e2e 44.92% <ø> (+0.02%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

codecov[bot] avatar Dec 28 '22 14:12 codecov[bot]

Looks like this PR is not ready to merge, because of the following issues:

  • This PR has conflicts, please resolve them before merging
  • This PR is missing the 'stat: QA assured' label
  • This PR is not mergeable
  • This PR is missing the required milestone or project

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

dionisio-bot[bot] avatar Apr 12 '24 19:04 dionisio-bot[bot]