Rocket.Chat icon indicating copy to clipboard operation
Rocket.Chat copied to clipboard

[IMPROVE] Endpoints

Open albuquerquefabio opened this issue 3 years ago • 9 comments

Proposed changes (including videos or screenshots)

/room.export - The logic was fixed. /dns.resolve.txt - For post request all params must be passed by body request /dns.resolve.srv and /dns.resolve.txt - These routes should handle DNS queries error exceptions

Issue(s)

  • /room.export
    • When one tries to export to email, that is with the param {"type": "email"}, we get the error "Cannot read property 'map' of undefined" ( even when "toUsers" and "toEmails" is provided)
    • Subject can not be empty and must be validate.

Steps to test or reproduce

Further comments

About the /dns.resolve.txt must be analyzed the impact. With this update all params are passed by body request which is the right way when using POST method.

albuquerquefabio avatar Jan 12 '22 21:01 albuquerquefabio

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Jan 12 '22 21:01 CLAassistant

This pull request fixes 1 alert when merging 13e4253015f50556114a3583d814469d4f7148ff into f357af4f952c002d70ffd96c2f019f2d7360aa20 - view on LGTM.com

fixed alerts:

  • 1 for Superfluous trailing arguments

lgtm-com[bot] avatar Nov 10 '22 17:11 lgtm-com[bot]

Codecov Report

Merging #24157 (f0e298e) into develop (364a153) will decrease coverage by 1.49%. The diff coverage is 0.00%.

:exclamation: Current head f0e298e differs from pull request most recent head 1b71bd2. Consider uploading reports for the commit 1b71bd2 to get more accurate results

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #24157      +/-   ##
===========================================
- Coverage    43.71%   42.23%   -1.49%     
===========================================
  Files          790      812      +22     
  Lines        15258    16052     +794     
  Branches      2084     2072      -12     
===========================================
+ Hits          6670     6779     +109     
- Misses        8310     8992     +682     
- Partials       278      281       +3     
Flag Coverage Δ
e2e 42.23% <0.00%> (-1.49%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

codecov[bot] avatar Nov 10 '22 18:11 codecov[bot]

This pull request fixes 1 alert when merging 5b5d6a1829b0dd27c63cf9d6687a7550c10f64ef into 9aec5457dda4f72dfb61c76d1544292885ce85fc - view on LGTM.com

fixed alerts:

  • 1 for Superfluous trailing arguments

lgtm-com[bot] avatar Nov 11 '22 00:11 lgtm-com[bot]

This pull request introduces 1 alert and fixes 1 when merging af527f77994b87e213836e02c0df14ab48f30308 into 2c829b18c9116985d01b3eac5bb8d218d52a2165 - view on LGTM.com

new alerts:

  • 1 for Useless assignment to local variable

fixed alerts:

  • 1 for Superfluous trailing arguments

Heads-up: LGTM.com's PR analysis will be disabled on the 5th of December, and LGTM.com will be shut down ⏻ completely on the 16th of December 2022. Please enable GitHub code scanning, which uses the same CodeQL engine :gear: that powers LGTM.com. For more information, please check out our post on the GitHub blog.

lgtm-com[bot] avatar Nov 18 '22 17:11 lgtm-com[bot]

This pull request introduces 1 alert and fixes 1 when merging 38e6585d9fc5e844287a90c9e90be000d4971e88 into 1be4ad2491e2eb04a30e6c01e4feaac7294807d2 - view on LGTM.com

new alerts:

  • 1 for Useless assignment to local variable

fixed alerts:

  • 1 for Superfluous trailing arguments

Heads-up: LGTM.com's PR analysis will be disabled on the 5th of December, and LGTM.com will be shut down ⏻ completely on the 16th of December 2022. Please enable GitHub code scanning, which uses the same CodeQL engine :gear: that powers LGTM.com. For more information, please check out our post on the GitHub blog.

lgtm-com[bot] avatar Nov 29 '22 14:11 lgtm-com[bot]

This pull request introduces 1 alert and fixes 1 when merging 153537d3b6a9136ff1051aa437523b0b13c39346 into 1be4ad2491e2eb04a30e6c01e4feaac7294807d2 - view on LGTM.com

new alerts:

  • 1 for Useless assignment to local variable

fixed alerts:

  • 1 for Superfluous trailing arguments

Heads-up: LGTM.com's PR analysis will be disabled on the 5th of December, and LGTM.com will be shut down ⏻ completely on the 16th of December 2022. Please enable GitHub code scanning, which uses the same CodeQL engine :gear: that powers LGTM.com. For more information, please check out our post on the GitHub blog.

lgtm-com[bot] avatar Nov 29 '22 15:11 lgtm-com[bot]

This pull request fixes 1 alert when merging 0f947956bfb1f39e9155957c405a28ffe528e6e1 into 557708a9eb5bf255f74cdc7d39e567d1708caaf6 - view on LGTM.com

fixed alerts:

  • 1 for Superfluous trailing arguments

Heads-up: LGTM.com's PR analysis will be disabled on the 5th of December, and LGTM.com will be shut down ⏻ completely on the 16th of December 2022. Please enable GitHub code scanning, which uses the same CodeQL engine :gear: that powers LGTM.com. For more information, please check out our post on the GitHub blog.

lgtm-com[bot] avatar Dec 06 '22 19:12 lgtm-com[bot]

This pull request fixes 1 alert when merging 47eae826f3d0bdcea83f16ba3e8bcd5699e89ce1 into 45415c37373e0984cb71ec2dbd13b0738ba30bed - view on LGTM.com

fixed alerts:

  • 1 for Superfluous trailing arguments

Heads-up: LGTM.com's PR analysis will be disabled on the 5th of December, and LGTM.com will be shut down ⏻ completely on the 16th of December 2022. Please enable GitHub code scanning, which uses the same CodeQL engine :gear: that powers LGTM.com. For more information, please check out our post on the GitHub blog.

lgtm-com[bot] avatar Dec 07 '22 18:12 lgtm-com[bot]

Placed Pierre as the assignee so that we can keep track of this item in the future.

casalsgh avatar Mar 24 '23 16:03 casalsgh