Header / Footer in plaintext emails

Open psy opened this issue 4 years ago • 18 comments

Description:

While the header and footer for emails can be customized via settings and is added to the html part of mails it is missing in the plaintext part. If header and footer are only used to style emails, this is mostly irrelevant. But as they may contain relevant information (e.g. a link to an imprint), they should also be added to the plaintext part of mails.

Steps to reproduce:

Look into source of an email sent by rocketchat
Find header / footer in html part
Search for it in plaintext part.

Expected behavior:

Header and footer should also be added to the plaintext part.

Actual behavior:

Plaintext part misses header and footer.

Server Setup Information:

Version of Rocket.Chat Server: 3.8.13
Operating System: Debian

Additional context

Example mail:

Subject: SMTP Test Email
Date: Sat, 04 Dec 2021 14:09:41 +0000
MIME-Version: 1.0

----_NmP-fe5a5cf915038dbf-Part_1
Content-Type: text/plain
Content-Transfer-Encoding: 7bit

You have successfully sent an email
----_NmP-fe5a5cf915038dbf-Part_1
Content-Type: text/html; charset=utf-8
Content-Transfer-Encoding: quoted-printable

<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN" "http://www.=
w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd"><html xmlns=3D"http://www.w3.=
org/1999/xhtml" style=3D"font-family: -apple-system,BlinkMacSystemFont,=
'Segoe UI',Roboto,Oxygen,Ubuntu,Cantarell,'Helvetica Neue','Apple Color =
Emoji','Segoe UI Emoji','Segoe UI Symbol','Meiryo UI',Arial,=
sans-serif;"><head><!-- If you delete this tag, the sky will fall on your =
head --><meta name=3D"viewport" content=3D"width=3Ddevice-width"><meta =
http-equiv=3D"Content-Type" content=3D"text/html; charset=3DUTF-8"><title>R=
ocket.Chat Cloud</title></head><body bgcolor=3D"#F7F8FA" =
style=3D"font-family: -apple-system,BlinkMacSystemFont,'Segoe UI',Roboto,=
Oxygen,Ubuntu,Cantarell,'Helvetica Neue','Apple Color Emoji','Segoe UI =
Emoji','Segoe UI Symbol','Meiryo UI',Arial,sans-serif; width: 100%; height:=
 100%;"><table class=3D"body" bgcolor=3D"#F7F8FA" width=3D"100%" =
style=3D"font-family: -apple-system,BlinkMacSystemFont,'Segoe UI',Roboto,=
Oxygen,Ubuntu,Cantarell,'Helvetica Neue','Apple Color Emoji','Segoe UI =
Emoji','Segoe UI Symbol','Meiryo UI',Arial,sans-serif; width: 100%; height:=
 100%;"><tr><td><!-- HEADER --><table class=3D"wrap" bgcolor=3D"#F7F8FA" =
style=3D"width: 100%; clear: both;"><tr><td class=3D"header container" =
style=3D"display: block; max-width: 640px; margin: 0 auto; clear: both; =
border-radius: 2px;"><div class=3D"header-content" style=3D"list-style-posi=
tion: inside; padding: 16px 0; padding-top: 36px; padding-bottom: 36px; =
padding-left: 36px; padding-right: 36px; max-width: 640px; margin: 0 auto; =
display: block;"><table bgcolor=3D"#F7F8FA" width=3D"100%"><tr><td><img =
src=3D"https://redacted/assets/logo.png" alt=3D"Rocket.chat" =
width=3D"150px"></td></tr></table></div></td></tr></table><!-- /HEADER =
--></td></tr><tr><td><!-- BODY --><table class=3D"wrap" style=3D"width: =
100%; clear: both;"><tr><td class=3D"container" bgcolor=3D"#FFFFFF" =
style=3D"display: block; max-width: 640px; margin: 0 auto; clear: both; =
border-radius: 2px;"><div class=3D"content" style=3D"list-style-position: =
inside; padding: 36px;"><table><tr><td> <p>You have successfully sent an =
email</p> </td></tr></table></div></td></tr></table><!-- /BODY =
--></td></tr><tr style=3D"margin: 0; padding: 0;"><td style=3D"margin: 0; =
padding: 0;"><!-- FOOTER --><table class=3D"wrap" style=3D"width: 100%; =
clear: both;"><tr><td class=3D"container" style=3D"display: block; =
max-width: 640px; margin: 0 auto; clear: both; border-radius: 2px;"><!-- =
content --><div class=3D"content" style=3D"list-style-position: inside; =
padding: 36px;"><table width=3D"100%"><tr><td align=3D"center" =
class=3D"social" style=3D"font-size: 12px;"><a href=3D"https://rocket.=
chat/blog" style=3D"color: #1D74F5; font-weight: bold; text-decoration: =
none; line-height: 1.8; padding-left: 2px; padding-right: 2px;">Blog</a> | =
<a href=3D"https://github.com/RocketChat" style=3D"color: #1D74F5; =
font-weight: bold; text-decoration: none; line-height: 1.8; padding-left: =
2px; padding-right: 2px;">Github</a> </td></tr><tr><td align=3D"center"><h6=
 style=3D"margin: 0 0 16px 0; font-weight: 500; font-size: 10px; color: =
#6c727A; line-height: 1.7;">=C2=A9 Rocket.Chat Technologies Corp.</h6><h6 =
style=3D"margin: 0 0 16px 0; font-weight: 500; font-size: 10px; color: =
#6c727A; line-height: 1.7;">Made with =E2=9D=A4=EF=B8=8F in =
=F0=9F=87=A7=F0=9F=87=B7 =F0=9F=87=A8=F0=9F=87=A6 =F0=9F=87=A9=F0=9F=87=AA =
=F0=9F=87=AE=F0=9F=87=B3 =F0=9F=87=AC=F0=9F=87=A7 =F0=9F=87=BA=F0=9F=87=B8 =
</h6></td></tr></table></div><!-- /content --></td></tr></table><!-- =
/FOOTER --></td></tr></table></body></html>

Dec 04 '21 14:12 psy