Rocket.Chat.js.SDK icon indicating copy to clipboard operation
Rocket.Chat.js.SDK copied to clipboard

Published 20 hours ago • verified publisher icon RocketChat

RestAPI improve error handling

Open mriedmann opened this issue 5 years ago • 6 comments

As far as I understand it, the current code does not allow to handle errors on api.get and api.post calls. I added rethrow instructions to work around this issue. If I got something wrong here, please help me find a way to handle api-errors in frontend with the current release.

If this is a "bug" please accept my PR. Thx!

mriedmann avatar Apr 26 '19 14:04 mriedmann

We are using this patch in production (with rocketchat-hubot) for quite a while now without any problems. Is there anything I can do to get this upstream?

mriedmann avatar Jul 25 '19 11:07 mriedmann

Hey, admin :D Merge this PR

gabrielrufino avatar Nov 14 '19 19:11 gabrielrufino

Maybe @sampaiodiego could give a short statement on this topic (RestAPI error handling)? It would be really great.

mriedmann avatar Nov 19 '19 11:11 mriedmann

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Mar 27 '20 14:03 CLAassistant

Hey! any update on this PR?

taimoorsaleem avatar Jun 06 '20 20:06 taimoorsaleem

@sampaiodiego Sorry to bother you, but this PR is quite useful, especially for bots

TBG-FR avatar Oct 15 '20 06:10 TBG-FR