Rocket.Chat.iOS icon indicating copy to clipboard operation
Rocket.Chat.iOS copied to clipboard

[NEW] Project 02 - Changing and adding servers VoiceOver accessible

Open rudrankriyam opened this issue 6 years ago • 1 comments

@RocketChat/ios

  • [x] Adding a new server follows the same steps as from the main authentication screen, with the option of sign up and login. It has been covered in the previous project.

  • [x] Servers can be added and changed using the ServersListView.

  • [x] However, instead of tapping the current server, double tapping on Messages opens and closes the ServersListView instead, which needs to be changed.

  • [x] Adding a comma between the accessibility label of Rocket.Chat and serverURL sounds a bit better by creating pause in VoiceOver dictation.

  • [x] Accessibility notifications for screen and layout changes

rudrankriyam avatar Aug 19 '19 07:08 rudrankriyam

Codecov Report

Merging #2750 into develop will decrease coverage by 1.56%. The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #2750      +/-   ##
===========================================
- Coverage     46.1%   44.54%   -1.57%     
===========================================
  Files          626      626              
  Lines        28938    28943       +5     
===========================================
- Hits         13343    12892     -451     
- Misses       15595    16051     +456
Impacted Files Coverage Δ
...ket.Chat/Views/Subscriptions/ServersListView.swift 0% <0%> (ø) :arrow_up:
...t/Views/Subscriptions/SubscriptionsTitleView.swift 42.5% <0%> (-2.24%) :arrow_down:
...ubscriptionsList/SubscriptionsViewController.swift 1.4% <0%> (-0.02%) :arrow_down:
Rocket.Chat/Views/Base/BaseNavigationBar.swift 0% <0%> (-100%) :arrow_down:
Rocket.Chat/Views/Chat/ChatAnnouncementView.swift 0% <0%> (-83.34%) :arrow_down:
...ontrollers/Chat/MessagesViewControllerTyping.swift 0% <0%> (-77.78%) :arrow_down:
...ntrollers/Chat/MessagesViewControllerJoining.swift 0% <0%> (-71.74%) :arrow_down:
...Chat/Models/Mapping/LoginServiceModelMapping.swift 0% <0%> (-66.3%) :arrow_down:
...odel/AuthSettingsManagerPersistencyExtension.swift 0% <0%> (-62%) :arrow_down:
...trollers/Chat/MessagesViewControllerDrafting.swift 20% <0%> (-60%) :arrow_down:
... and 20 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 2f5ad00...84be45e. Read the comment docs.

codecov[bot] avatar Aug 19 '19 07:08 codecov[bot]