[WIP] [NEW] Project 08 - Adding Reactions VoiceOver accessible
@RocketChat/ios
- [x] To open the Add Reactions View, double tap on the name and hold it for a second. (The Voice Over way of long press)
- [x] Categories.custom / categories.recent and all the other categories need to be assigned an accessibility label, which are defined in the RCEmojiKit.strings. Currently, they are described in VoiceOver as “Tab x of 10” button.
- [x] The skinTone button needs to be assigned accessibilityLabel = “Change Skin Tone”
- [x] Added current skin tone for the skinTone button
- [x] The custom emojis are not tapped as single elements, but as a whole view.
- [x] Add the labels for each custom emoji.
- [x] Fixed custom emojis bug.
- [x] Header accessibility for emoji category.
Codecov Report
Merging #2746 into develop will decrease coverage by
0.01%. The diff coverage is0%.
@@ Coverage Diff @@
## develop #2746 +/- ##
===========================================
- Coverage 46.1% 46.09% -0.02%
===========================================
Files 626 626
Lines 28938 28946 +8
===========================================
Hits 13343 13343
- Misses 15595 15603 +8
| Impacted Files | Coverage Δ | |
|---|---|---|
| ...nal/RCEmojiKit/Views/EmojiPicker/EmojiPicker.swift | 0% <0%> (ø) |
:arrow_up: |
| ...it/Views/EmojiPicker/EmojiCollectionViewCell.swift | 0% <0%> (ø) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing dataPowered by Codecov. Last update 2f5ad00...46d200c. Read the comment docs.
Thank you for your review @Sameesunkaria !
And thanks for the skin tone names! I will edit the skinTone array from
let skinTones: [(name: String?, color: UIColor)]
to
let skinTones: [(name: String?, color: UIColor, accessibilityName: String?)]
For the default skinTone, I don't know why nil was used for the name. I will edit the accessibilityName to default.