Rocket.Chat.iOS icon indicating copy to clipboard operation
Rocket.Chat.iOS copied to clipboard

[NEW][WIP] Added unhiding channel after hiding.

Open tmbiOS opened this issue 5 years ago • 7 comments

@RocketChat/ios Need help: can't reload subscriptions after opening room.

Closes #2158

tmbiOS avatar Feb 26 '19 15:02 tmbiOS

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Feb 26 '19 15:02 CLAassistant

Codecov Report

Merging #2566 into develop will decrease coverage by 0.05%. The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #2566      +/-   ##
===========================================
- Coverage    26.49%   26.44%   -0.06%     
===========================================
  Files          456      457       +1     
  Lines        16903    16940      +37     
===========================================
  Hits          4479     4479              
- Misses       12424    12461      +37
Impacted Files Coverage Δ
Rocket.Chat/API/Clients/SubscriptionsClient.swift 62.8% <0%> (-4.21%) :arrow_down:
...ocket.Chat/API/Requests/Room/RoomOpenRequest.swift 0% <0%> (ø)
...ubscriptionsList/SubscriptionsViewController.swift 2.46% <0%> (-0.02%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 176750f...c0ed547. Read the comment docs.

codecov[bot] avatar Feb 26 '19 15:02 codecov[bot]

@RocketChat/ios Need help: can't reload subscriptions after opening room.

tmbiOS avatar Feb 28 '19 06:02 tmbiOS

@tmbiOS Please try adding also the auth property to the Subscription, using Auth.isAuthenticated() method to get the correct instance.

rafaelks avatar Feb 28 '19 08:02 rafaelks

@tmbiOS Do you have plans to finish this PR at any time? Thank you!

rafaelks avatar Apr 02 '19 12:04 rafaelks

@tmbiOS Do you have plans to finish this PR at any time? Thank you!

Hi, @rafaelks ! I'm planning to finish PR next week (and open new PR). Should I write the tests?

tmbiOS avatar Apr 03 '19 19:04 tmbiOS

@tmbiOS Yes, please! :-)

rafaelks avatar Apr 03 '19 20:04 rafaelks