Rocket.Chat.iOS
Rocket.Chat.iOS copied to clipboard
[NEW][WIP] Added unhiding channel after hiding.
@RocketChat/ios Need help: can't reload subscriptions after opening room.
Closes #2158
Codecov Report
Merging #2566 into develop will decrease coverage by
0.05%
. The diff coverage is0%
.
@@ Coverage Diff @@
## develop #2566 +/- ##
===========================================
- Coverage 26.49% 26.44% -0.06%
===========================================
Files 456 457 +1
Lines 16903 16940 +37
===========================================
Hits 4479 4479
- Misses 12424 12461 +37
Impacted Files | Coverage Δ | |
---|---|---|
Rocket.Chat/API/Clients/SubscriptionsClient.swift | 62.8% <0%> (-4.21%) |
:arrow_down: |
...ocket.Chat/API/Requests/Room/RoomOpenRequest.swift | 0% <0%> (ø) |
|
...ubscriptionsList/SubscriptionsViewController.swift | 2.46% <0%> (-0.02%) |
:arrow_down: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 176750f...c0ed547. Read the comment docs.
@RocketChat/ios Need help: can't reload subscriptions after opening room.
@tmbiOS Please try adding also the auth
property to the Subscription, using Auth.isAuthenticated() method to get the correct instance.
@tmbiOS Do you have plans to finish this PR at any time? Thank you!
@tmbiOS Do you have plans to finish this PR at any time? Thank you!
Hi, @rafaelks ! I'm planning to finish PR next week (and open new PR). Should I write the tests?
@tmbiOS Yes, please! :-)