fix: typescript migration helpers 6781

[DSingh0304]

Proposed changes

This PR completes the TypeScript migration for app/lib/methods/helpers/helpers.ts by removing the @ts-nocheck directive and adding proper type annotations to all helper functions.

Key changes:

• Removed @ts-nocheck directive from helpers.ts
• Added comprehensive TypeScript types and JSDoc comments to all 8 exported helper functions
• Created TRoomLike type alias to handle both IRoom and ISubscription objects flexibly
• Updated function signatures to handle undefined inputs gracefully, ensuring type safety
• Added null checks in calling code (RoomActionsView, RoomInfoView, RoomView) to prevent passing undefined values to getUserInfo

All functions now have proper type annotations:

• isGroupChat, getRoomAvatar, getUidDirectMessage, getRoomTitle, getSenderName, canAutoTranslate, isRead, hasRole, hasPermission

Issue(s)

Fixes #6781

How to test or reproduce

1. Run yarn tsc --noEmit to verify TypeScript compilation passes without errors
2. Run yarn lint app/lib/methods/helpers/helpers.ts to verify ESLint passes
3. Test the following screens to ensure functionality remains unchanged:
   • Room Actions View
   • Room Info View
   • Room View (main chat screen)
4. Verify direct message user info loading works correctly
5. Verify room titles and avatars display properly

Screenshots

N/A - Type-only changes, no visual modifications

Types of changes

• [ ] Bugfix (non-breaking change which fixes an issue)
• [x] Improvement (non-breaking change which improves a current function)
• [ ] New feature (non-breaking change which adds functionality)
• [ ] Documentation update (if none of the other choices apply)

Checklist

• [x] I have read the CONTRIBUTING doc
• [x] I have signed the CLA
• [x] Lint and unit tests pass locally with my changes
• [ ] I have added tests that prove my fix is effective or that my feature works (if applicable)
• [x] I have added necessary documentation (if applicable)
• [ ] Any dependent changes have been merged and published in downstream modules

Further comments

This is a type-safety improvement with no runtime behavior changes. The TypeScript migration ensures better code maintainability and catches potential type errors at compile time. All existing functionality is preserved while improving type safety across the codebase.

Verification completed:

• ✅ TypeScript compilation: 0 errors in application code
• ✅ Metro bundler: Successfully builds for Android
• ✅ ESLint: Passes with no errors/warnings
• ✅ Git status: Clean working directory with only 4 files modified (85 insertions, 40 deletions)

Summary by CodeRabbit

• Bug Fixes

  • Avoided unnecessary user-info fetches when identifiers are missing; prevents runtime errors.
  • Ensured room titles, names and related props always resolve to defined strings (safe fallbacks).
  • Coerced permission checks and boolean results to avoid undefined values.

• Refactor

  • Improved null-safety and type robustness across helpers, hooks and views.
  • Made avatar fields optional so missing avatars render safely.
  • Hardened read/unread, sender-name and permission handling to reduce edge-case failures.

• Documentation

  • Added JSDoc-style comments for clearer intent and maintenance.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

[coderabbitai[bot]]

Walkthrough

Adds TypeScript typings and null-safety to helpers in app/lib/methods/helpers/helpers.ts; makes avatar props optional; and guards calls to getUserInfo and room-title usages across multiple view and container components to ensure safe fallbacks.

Changes

Cohort / File(s)	Summary
TypeScript migration & null-safety for helpers app/lib/methods/helpers/helpers.ts	Remove @ts-nocheck; introduce internal TRoomLike; add/strengthen types and JSDoc for exported helpers (e.g., `isGroupChat(room: Partial<TRoomLike>
Guard getUserInfo with roomUserId checks (views) app/views/RoomActionsView/index.tsx, app/views/RoomInfoView/index.tsx, app/views/RoomView/index.tsx	Only call getUserInfo when roomUserId is truthy; adjust calls to getUidDirectMessage to pass `r
Make avatar fields optional across UI components app/containers/CallHeader.tsx, app/containers/InAppNotification/IncomingCallNotification/index.tsx, app/containers/InAppNotification/NotifierComponent.tsx, app/containers/RoomItem/interfaces.ts	Change avatar from required string to optional (`string
UI guards and string fallbacks app/containers/RoomItem/index.tsx, app/views/AddExistingChannelView/index.tsx, app/views/CreateDiscussionView/SelectChannel.tsx, app/views/CreateDiscussionView/SelectUsers.tsx, app/views/ForwardMessageView/SelectPersonOrChannel.tsx, app/views/RoomInfoEditView/index.tsx, app/views/ShareView/Header.tsx	Use `getRoomTitle(...)
Permissions boolean-hardening app/views/RoomActionsView/index.tsx, app/containers/MessageActions/index.tsx, app/views/RoomView/RightButtons.tsx, app/views/ShareView/index.tsx	Ensure permission results coerce to boolean (e.g., `permissions[0]
Typed hook state app/lib/hooks/useUserData.ts	Add explicit useState typing for user data: { username: string; avatar?: string; uid: string; type: string; direct: boolean }.
RoomItem rendering fallback app/containers/RoomItem/index.tsx	Pass `name

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~25 minutes

• Areas needing extra attention:
  • hasPermission async flow: room role loading, role merging, and error fallback behavior.
  • Callers previously expecting null vs now receiving undefined from getUidDirectMessage.
  • UI code that assumed avatars are always present — verify fallbacks and rendering across components.
  • Correctness of TRoomLike fields for federated and direct-message shapes.

Possibly related PRs

• RocketChat/Rocket.Chat.ReactNative#6758 — modifies app/containers/RoomItem/interfaces.ts (avatar/props changes) and adds related interface fields; likely overlaps with avatar optionality changes.

Suggested reviewers

• OtavioStasiak
• diegolmello

Poem

🐰 I hopped through code with careful paws,
Typed the helpers and fixed the laws.
Avatars optional, titles never nil,
Guards in place to keep calls still.
A small rabbit's tweak — tidy and chill. 🥕

Pre-merge checks and finishing touches

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The PR title clearly describes the main change: removing @ts-nocheck and adding TypeScript types to helpers. It directly matches the primary objective in the linked issue #6781.
Linked Issues check	✅ Passed	The PR successfully addresses all objectives from issue #6781: removed @ts-nocheck, added complete TypeScript annotations and JSDoc to all 8 exported functions (isGroupChat, getRoomAvatar, getUidDirectMessage, getRoomTitle, getSenderName, canAutoTranslate, isRead, hasRole, hasPermission), introduced TRoomLike type, and updated downstream callers.
Out of Scope Changes check	✅ Passed	All changes are directly aligned with #6781 objectives: TypeScript migration of helpers.ts and necessary downstream updates in RoomActionsView, RoomInfoView, RoomView, and type definitions. No unrelated modifications detected.
Docstring Coverage	✅ Passed	Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.

✨ Finishing touches

• [ ] 📝 Generate docstrings

🧪 Generate unit tests (beta)

• [ ] Create PR with unit tests
• [ ] Post copyable unit tests in a comment

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}