Rocket.Chat.ReactNative icon indicating copy to clipboard operation
Rocket.Chat.ReactNative copied to clipboard

Changing ProfileView Class Component to Hook Component

Open anirbanpaulcom opened this issue 10 months ago • 2 comments

Proposed changes

Changing ProfileView from a class component to a hook component for using react-hook-form .

Issue(s)

Solves This Issue : #5544

How to test or reproduce

Screenshots

Types of changes

  • [x] Bugfix (non-breaking change which fixes an issue)
  • [ ] Improvement (non-breaking change which improves a current function)
  • [ ] New feature (non-breaking change which adds functionality)
  • [ ] Documentation update (if none of the other choices apply)

Checklist

  • [x] I have read the CONTRIBUTING doc
  • [ ] I have signed the CLA
  • [ ] Lint and unit tests pass locally with my changes
  • [ ] I have added tests that prove my fix is effective or that my feature works (if applicable)
  • [ ] I have added necessary documentation (if applicable)
  • [ ] Any dependent changes have been merged and published in downstream modules

Further comments

anirbanpaulcom avatar Apr 08 '24 17:04 anirbanpaulcom

@GleidsonDaniel , @diegolmello , Please take a look.

anirbanpaulcom avatar Apr 10 '24 19:04 anirbanpaulcom

Hey @diegolmello, #5544 this PR is for integrating react-hook-form Let me know if any other files, like RegisterView need to be changed from class to function components. Thank you.

anirbanpaulcom avatar Sep 20 '24 15:09 anirbanpaulcom