Rocket.Chat.ReactNative icon indicating copy to clipboard operation
Rocket.Chat.ReactNative copied to clipboard

fix: remove unfollowed threads

Open sanjaysargam opened this issue 1 year ago • 4 comments

Proposed changes

Threads updating immediately if unfollowed in Following Filter

Issue(s)

Fixes #5503

How to test or reproduce

  1. Go to RoomView
  2. Click on Threads
  3. Select display following filter
  4. Unfollow any one of the thread

Screenshots

https://github.com/RocketChat/Rocket.Chat.ReactNative/assets/65113071/0213d4bf-43cd-457a-b3b1-490bc037ad09

Types of changes

  • [x] Bugfix (non-breaking change which fixes an issue)
  • [ ] Improvement (non-breaking change which improves a current function)
  • [ ] New feature (non-breaking change which adds functionality)
  • [ ] Documentation update (if none of the other choices apply)

Checklist

  • [x] I have read the CONTRIBUTING doc
  • [x] I have signed the CLA
  • [x] Lint and unit tests pass locally with my changes
  • [ ] I have added tests that prove my fix is effective or that my feature works (if applicable)
  • [ ] I have added necessary documentation (if applicable)
  • [ ] Any dependent changes have been merged and published in downstream modules

Further comments

sanjaysargam avatar Jan 21 '24 12:01 sanjaysargam

Can you add an e2e test?

dnlsilva avatar Jan 31 '24 16:01 dnlsilva

Can you add an e2e test?

Please guide me on how I can add the e2e test, or are there any docs for this?

sanjaysargam avatar Jan 31 '24 17:01 sanjaysargam

Can you add an e2e test?

Please guide me on how I can add the e2e test, or are there any docs for this?

https://github.com/RocketChat/Rocket.Chat.ReactNative/tree/develop/e2e

If you have any doubts, just tell me. In this case, you would just add a test to check whether the item really disappeared from the list.

dnlsilva avatar Jan 31 '24 17:01 dnlsilva

@GleidsonDaniel I read the documentation but didn't understand how to write tests. Is there any merged PR who wrote the test in it, so that I can refer.

sanjaysargam avatar Feb 01 '24 17:02 sanjaysargam