Rocket.Chat.ReactNative icon indicating copy to clipboard operation
Rocket.Chat.ReactNative copied to clipboard

feat: add sort functionality in directory

Open brf153 opened this issue 1 year ago • 7 comments

Proposed changes

https://github.com/RocketChat/Rocket.Chat.ReactNative/assets/107868772/77193fe8-6f37-4179-876d-57a19287be73

Issue(s)

closes #5423

How to test or reproduce

Check the sort button in the directory

Screenshots

Types of changes

  • [ ] Bugfix (non-breaking change which fixes an issue)
  • [x] Improvement (non-breaking change which improves a current function)
  • [ ] New feature (non-breaking change which adds functionality)
  • [ ] Documentation update (if none of the other choices apply)

Checklist

  • [x] I have read the CONTRIBUTING doc
  • [x] I have signed the CLA
  • [x] Lint and unit tests pass locally with my changes
  • [ ] I have added tests that prove my fix is effective or that my feature works (if applicable)
  • [ ] I have added necessary documentation (if applicable)
  • [x] Any dependent changes have been merged and published in downstream modules

brf153 avatar Jan 02 '24 14:01 brf153

@GleidsonDaniel please review this. I think I have fixed the lint problem.

brf153 avatar Jan 02 '24 14:01 brf153

@brf153 just one comment, the title is wrong. 1 - feat(sort) is wrong, because the feat explains the type of commit, if it is feat, regression, bug, fix etc, then it should just be the "title". 2 - adding is wrong too, because the PR is not "adding", it adds "add" a new functionality. Other than that, I'm going to review the PR, I've already corrected the title. It's not a criticism, it's just a tip for continued improvement.

dnlsilva avatar Jan 02 '24 14:01 dnlsilva

@GleidsonDaniel Your guidance is invaluable, and I'm always open to suggestions for improvement. Thanks again for your help!

brf153 avatar Jan 02 '24 14:01 brf153

https://github.com/RocketChat/Rocket.Chat.ReactNative/assets/107868772/0cf37ecd-10c8-4176-ba7e-bdce604f459a

brf153 avatar Jan 03 '24 15:01 brf153

@GleidsonDaniel I have implemented several enhancements, extending the functionality of the sorting feature to include users and teams as well.

brf153 avatar Jan 03 '24 15:01 brf153

Where did you get these translations and these log tags?

dnlsilva avatar Jan 19 '24 21:01 dnlsilva

I got the translations from ChatGPT.

brf153 avatar Jan 20 '24 05:01 brf153