Rocket.Chat.ReactNative
Rocket.Chat.ReactNative copied to clipboard
feat: add sort functionality in directory
Proposed changes
https://github.com/RocketChat/Rocket.Chat.ReactNative/assets/107868772/77193fe8-6f37-4179-876d-57a19287be73
Issue(s)
closes #5423
How to test or reproduce
Check the sort button in the directory
Screenshots
Types of changes
- [ ] Bugfix (non-breaking change which fixes an issue)
- [x] Improvement (non-breaking change which improves a current function)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Documentation update (if none of the other choices apply)
Checklist
- [x] I have read the CONTRIBUTING doc
- [x] I have signed the CLA
- [x] Lint and unit tests pass locally with my changes
- [ ] I have added tests that prove my fix is effective or that my feature works (if applicable)
- [ ] I have added necessary documentation (if applicable)
- [x] Any dependent changes have been merged and published in downstream modules
@GleidsonDaniel please review this. I think I have fixed the lint problem.
@brf153 just one comment, the title is wrong. 1 - feat(sort) is wrong, because the feat explains the type of commit, if it is feat, regression, bug, fix etc, then it should just be the "title". 2 - adding is wrong too, because the PR is not "adding", it adds "add" a new functionality. Other than that, I'm going to review the PR, I've already corrected the title. It's not a criticism, it's just a tip for continued improvement.
@GleidsonDaniel Your guidance is invaluable, and I'm always open to suggestions for improvement. Thanks again for your help!
https://github.com/RocketChat/Rocket.Chat.ReactNative/assets/107868772/0cf37ecd-10c8-4176-ba7e-bdce604f459a
@GleidsonDaniel I have implemented several enhancements, extending the functionality of the sorting feature to include users and teams as well.
Where did you get these translations and these log tags?
I got the translations from ChatGPT.