Rocket.Chat.ReactNative
Rocket.Chat.ReactNative copied to clipboard
Switch color doesn't match with App's Theme
Description:
Environment Information:
- Rocket.Chat Server Version: 6.5.0
- Rocket.Chat App Version: 4.44.0+
- Device Name: Realme 9
- OS Version: Android
Steps to reproduce:
- Go to Display from DrawerNavigation
- Turn on Avatars Switch
Expected behavior:
The color of the switch should match with App's theme
Actual behavior:
The switch color doesn't match with App's Theme
Additional context:
Hey @SanjaySargam, I would like to know the current status of the resolution of this issue from you. Are you still working on it?
Hi Hey @GuptaPrisha . I already made a PR. You can work on other issues.
Hello @SanjaySargam,
Actually I have worked on this issue and completed it with the jest
tests too.
Are you willing to collaborate on this issue? I can see your tests failing in the PR you made.
Thanks Prisha
There are several Switch on the app. Also I can see the track color is still the same. Can you create a reusable Switch and apply everywhere?
@GuptaPrisha Did you consider this
@SanjaySargam Yes! I made it reusable and adaptable. I made sure that it works well with other components which are already using the react-native's switch component.
Also, I applied it everywhere the native switch was getting used.
But I already made a PR. I will check why the jest is failing and resolve it. And from the next time, check whether anyone is assigned to an issue or made a PR and then start working on it.