Rocket.Chat.ReactNative icon indicating copy to clipboard operation
Rocket.Chat.ReactNative copied to clipboard

Published 20 hours ago • verified publisher icon RocketChat

feat: play audios in sequence automatically

Open jsathu07 opened this issue 1 year ago • 7 comments

Proposed changes

Implemented a sequence of audio files in a room to play automatically. Whenever a user clicks on an audio, if there is another audio below it, it will play automatically until there is something other than an audio.

Issue(s)

closes #4688

How to test or reproduce

Screenshots

https://github.com/RocketChat/Rocket.Chat.ReactNative/assets/61021881/f3c2dab2-dd4f-4527-8d10-82d510b0ce5d

Types of changes

  • [ ] Bugfix (non-breaking change which fixes an issue)
  • [x] Improvement (non-breaking change which improves a current function)
  • [ ] New feature (non-breaking change which adds functionality)
  • [ ] Documentation update (if none of the other choices apply)

Checklist

  • [x] I have read the CONTRIBUTING doc
  • [x] I have signed the CLA
  • [x] Lint and unit tests pass locally with my changes
  • [ ] I have added tests that prove my fix is effective or that my feature works (if applicable)
  • [ ] I have added necessary documentation (if applicable)
  • [ ] Any dependent changes have been merged and published in downstream modules

Further comments

  • I used array index since we can't identify the order of audio messages using msg id.
  • This only works if the previous audio is loaded (which must be in accordance with the rendering order), except when auto media download is off or there are network issues.
  • This functionality works with multiple rooms since all audios are unloaded when exiting a room.

jsathu07 avatar Dec 12 '23 09:12 jsathu07

Hi @diegolmello sir, Could you please check this PR and let me know if there are any issues? Thank you.

jsathu07 avatar Dec 13 '23 18:12 jsathu07

@diegolmello Sir, I have implemented the requested changes

jsathu07 avatar Dec 16 '23 13:12 jsathu07

@jsathu07 Hi, Are you still working on this issue? If not, I would like to work on it.

abhinav700 avatar Jan 18 '24 06:01 abhinav700

@jsathu07 Hi, Are you still working on this issue? If not, I would like to work on it.

@abhinav700 I've completed the task a month ago and now waiting for a review. If you have better solution feel free to work on it

jsathu07 avatar Jan 18 '24 08:01 jsathu07

@jsathu07 Thanks for responding. I will look for some other issue to work on.

abhinav700 avatar Jan 19 '24 09:01 abhinav700

@reinaldonetof, I've implemented the requested changes sir. Thank you for your guidance.

jsathu07 avatar Jan 25 '24 11:01 jsathu07

@reinaldonetof, I've done the changes sir

jsathu07 avatar Jan 26 '24 11:01 jsathu07