Rocket.Chat.ReactNative icon indicating copy to clipboard operation
Rocket.Chat.ReactNative copied to clipboard

Added changes to fix the markdown for mention user

Open brf153 opened this issue 1 year ago • 2 comments

Proposed changes

Fixed the bug in the markup so that it now works for user mentions.

Issue(s)

closes #5302 Depends on https://github.com/RocketChat/fuselage/pull/1228

How to test or reproduce

Create a message using various Markdown formatting options and include mentions using '@'. For instance, *Hello @brf153, how are you?*

Screenshots

From WhatsApp Image 2023-11-27 at 21 59 58

To WhatsApp Image 2023-11-27 at 21 55 54

Types of changes

  • [x] Bugfix (non-breaking change which fixes an issue)
  • [x] Improvement (non-breaking change which improves a current function)
  • [x] New feature (non-breaking change which adds functionality)
  • [ ] Documentation update (if none of the other choices apply)

Checklist

  • [x] I have read the CONTRIBUTING doc
  • [x] I have signed the CLA
  • [x] Lint and unit tests pass locally with my changes
  • [ ] I have added tests that prove my fix is effective or that my feature works (if applicable)
  • [ ] I have added the necessary documentation (if applicable)
  • [ ] Any dependent changes have been merged and published in downstream modules

Additional Comment

I need to add changes to the fuselage repository of Rocket Chat. After that, this pull request will work fine.

brf153 avatar Nov 27 '23 16:11 brf153

Thanks for your contribution, @brf153! We're going to evaluate this asap. Just be aware we're in the middle of a long release, so it might take longer than expected to review it.

diegolmello avatar Nov 29 '23 13:11 diegolmello

@diegolmello Sure sir

brf153 avatar Nov 29 '23 14:11 brf153