Rocket.Chat.ReactNative icon indicating copy to clipboard operation
Rocket.Chat.ReactNative copied to clipboard

:p rendered as custom emoji :p: in quote

Open paulchen opened this issue 2 years ago • 9 comments

Description:

If a custom emoji with the name p is configured, :p will be rendered as custom emoji in quotes.

Environment Information:

  • Rocket.Chat Server Version: 6.4.3
  • Rocket.Chat App Version: 4.42.0.50842
  • Device Name: ELE-L29 (Huawei P30)
  • OS Version: EMUI 12.0.0 (Android 11)

Steps to reproduce:

  1. Configure a custom emoji with name p.
  2. Write a message containing :p. No emoji should be rendered in this message as for the custom emoji :p: must be used.
  3. Write a second message quoting the first one.

Expected behavior:

In the quote in the second message, no emoji is rendered.

Actual behavior:

Screenshot_20231027_005302

Additional context:

I tried the same steps as above, but using the emoji name a instead of p. That way I was unable to reproduce the issue.

The extremely beautiful image I uploaded as custom emoji is this one: p

In the browser version of Rocket.Chat, this works as expected.

paulchen avatar Oct 26 '23 23:10 paulchen

Hii @paulchen! I am confident in solving this issue. Can you please assign it to me.

GopalVerma1303 avatar Dec 31 '23 14:12 GopalVerma1303

Hii @paulchen! I am confident in solving this issue. Can you please assign it to me.

No, I can't, for two reasons:

  • I'm not a member of the Rocket.Chat team so I don't have any permissions here.
  • The Rocket.Chat team does not assign issues to people who are not part of the team.

However, feel free to fix the issue and submit a pull request.

paulchen avatar Dec 31 '23 16:12 paulchen

Cool! I am working on this issue. Thanks @paulchen

GopalVerma1303 avatar Dec 31 '23 16:12 GopalVerma1303

Cool! I am working on this issue. Thanks @paulchen

Hey @GopalVerma1303 as you are working with it, can you create at least a draft PR? Just to track with the team! Thanks for your support 🚀

reinaldonetof avatar Jan 04 '24 14:01 reinaldonetof

Sure @reinaldonetof!

GopalVerma1303 avatar Jan 04 '24 15:01 GopalVerma1303

Jira: TC-1000

dnlsilva avatar Jan 10 '24 18:01 dnlsilva

hi @GleidsonDaniel, it seems this issue is still open and no PR is there. can I work on it if this issue is still there?

AmitGiriDev avatar Feb 04 '24 21:02 AmitGiriDev

hi @GleidsonDaniel, it seems this issue is still open and no PR is there. can I work on it if this issue is still there?

Yes, you can work on that.

dnlsilva avatar Feb 04 '24 22:02 dnlsilva

Hey @Amitlpu-840, are you still on this issue?

preeesha avatar Feb 09 '24 19:02 preeesha

Is this issue is still open, as i want to work on it ?

Tushargupta002 avatar Nov 10 '24 11:11 Tushargupta002

Is this issue is still open, as i want to work on it ?

I just verified that it is still present in Rocket.Chat 7.0.0.

paulchen avatar Nov 10 '24 21:11 paulchen

Ok, i am working on it .

Tushargupta002 avatar Nov 11 '24 07:11 Tushargupta002

@Tushargupta002 has the issue resolved?

muhamadjawad avatar Nov 13 '24 12:11 muhamadjawad

Cannot reproduce this issue

Device: IQOO Neo 7 Pro Android OS: 13 App Version: 4.54.1.68653 Server version: 7.0.0

Screenshot_2024_1201_103214.jpg

Rohit3523 avatar Dec 01 '24 05:12 Rohit3523

Screenshot_2024_1201_103557.jpg

Rohit3523 avatar Dec 01 '24 05:12 Rohit3523

Cannot reproduce this issue

That's interesting. It is still present at my installation.

share_7080037420623164685

Environment Information:

  • Rocket.Chat Server Version: 7.0.0
  • Rocket.Chat App Version: 4.55.0.70132
  • Device Name: Pixel 8
  • OS Version: Android 15

paulchen avatar Dec 01 '24 23:12 paulchen

@paulchen can you provide a screen recording?

Rohit3523 avatar Dec 02 '24 08:12 Rohit3523

@paulchen are u still facing this issue? have checked and its not occuring again

deepak0x avatar Nov 26 '25 21:11 deepak0x

@paulchen are u still facing this issue? have checked and its not occuring again

I just checked it myself and can confirm that this problem has been fixed meanwhile. Hence, I close this issue now.

@deepakbhagatiitr Thanks for checking!

paulchen avatar Nov 26 '25 22:11 paulchen