Rocket.Chat.ReactNative icon indicating copy to clipboard operation
Rocket.Chat.ReactNative copied to clipboard

Error: Each child in a list should have a unique "key" prop

Open indresh149 opened this issue 2 years ago • 10 comments

Description:

Each child in a list should have a unique "key" prop in inline at the paragraph.tsx It is giving error after running the app first time.

Environment Information: Rocket.Chat Server Version: 4.8.7 Rocket.Chat App Version: 4.35.1 Single Server Device Name: Android OS Version: Android 10

Steps to reproduce:

It is giving error after running the app first time. in logs

Screenshot image

indresh149 avatar Mar 02 '23 21:03 indresh149

Hey @diegolmello, Can you please have a look at this issue, and assign it to me? I want to take this up.

indresh149 avatar Mar 03 '23 06:03 indresh149

Hey. Just work on it. You can contribute without an assignment. Thanks!

diegolmello avatar Mar 03 '23 11:03 diegolmello

ok, @diegolmello I will try to fix it. Thanks for the reply

indresh149 avatar Mar 03 '23 15:03 indresh149

@indresh149 have you solved it ? or still it is pending?

ankitpanchaal avatar Sep 07 '23 09:09 ankitpanchaal

I can work on this issue. But I see this in more places as well. This is generally not a good coding practice to use components without the key prop, this makes react less efficient, the key props help with the DOM manipulation.

Screenshot 2023-10-08 at 5 45 06 PM Screenshot 2023-10-08 at 5 45 19 PM

But this is not expected from a project like this. It is a very basic practice to keep in mind. Am I missing something?

manancodes avatar Oct 08 '23 12:10 manancodes

Hey @indresh149, I see you mentioned that you are working on this issue. What's the status? Are you still on it or I can start resolving the same?

Thanks Prisha

preeesha avatar Dec 27 '23 17:12 preeesha

@GuptaPrisha you can start resolving

indresh149 avatar Dec 28 '23 04:12 indresh149

Okay Thanks I am working on this.

preeesha avatar Dec 28 '23 04:12 preeesha

hi @GleidsonDaniel, this issue is still open, so should I work on fixing it and link a new pull request?

AmitGiriDev avatar Feb 04 '24 07:02 AmitGiriDev

Heyy @Amitlpu-840, we are already working on this issue in tagged PR.

preeesha avatar Feb 06 '24 18:02 preeesha