Rocket.Chat.ReactNative icon indicating copy to clipboard operation
Rocket.Chat.ReactNative copied to clipboard

[IMPROVE] Spotlight users order

Open reinaldonetof opened this issue 3 years ago • 2 comments

Proposed changes

Improve the search by the user at MessageBox to keep the same behavior as a web application, also fix the spotlight and add a param for rid when exists

Issue(s)

Closes https://github.com/RocketChat/Rocket.Chat.ReactNative/issues/3681 Closes https://github.com/RocketChat/Rocket.Chat.ReactNative/pull/4011

How to test or reproduce

Screenshots

First interaction with @


Screen Shot 2022-09-14 at 13 35 37

https://user-images.githubusercontent.com/47038980/190215911-dbd9b58b-0c66-4981-9056-7da978b2ee5e.mov

Interaction with @a


Screen Shot 2022-09-14 at 13 37 34

https://user-images.githubusercontent.com/47038980/190216803-e246085f-1dde-4e4c-843d-d8b8a077dc30.mov

Types of changes

  • [ ] Bugfix (non-breaking change which fixes an issue)
  • [x] Improvement (non-breaking change which improves a current function)
  • [ ] New feature (non-breaking change which adds functionality)
  • [ ] Documentation update (if none of the other choices apply)

Checklist

  • [x] I have read the CONTRIBUTING doc
  • [x] I have signed the CLA
  • [x] Lint and unit tests pass locally with my changes
  • [ ] I have added tests that prove my fix is effective or that my feature works (if applicable)
  • [ ] I have added necessary documentation (if applicable)
  • [ ] Any dependent changes have been merged and published in downstream modules

Further comments

Jira: TC-37

reinaldonetof avatar Sep 14 '22 16:09 reinaldonetof

Wait a lot that PR is merged

ankar84 avatar Sep 28 '22 06:09 ankar84

@ankar84 we're releasing 4.31.0. We want to land this fix on 4.32.0

diegolmello avatar Sep 28 '22 12:09 diegolmello