Rocket.Chat.Electron icon indicating copy to clipboard operation
Rocket.Chat.Electron copied to clipboard

Adding VisualElementsManifest

Open mdesign83 opened this issue 6 years ago • 4 comments

My Setup

  • Operating System: WIN10

  • App Version: 2.10.5

  • [x] I have tested with the latest version

  • [x] I can simulate the issue easily

Description

When I pin Rocket.Chat+ to the Start the icon has the default blue background.

Current Behavior

Pinned application's background is vivid blue.

Expected Behavior

Pinned application background should be the new dark grey.

Solution

Place a "Rocket.Chat+.VisualElementsManifest.xml" file next to Rocket.Chat+.exe

<Application xmlns:xsi='http://www.w3.org/2001/XMLSchema-instance'>
  <VisualElements
      ShowNameOnSquare150x150Logo='on'
      ForegroundText='light'
      BackgroundColor='#2f343d'/>
</Application>

screenshot

mdesign83 avatar Feb 16 '18 13:02 mdesign83

@mdesign83 Hey, since you know the needed change, what do you think about doing a PR to fix this? Thanks for the feedback!

gdelavald avatar Feb 16 '18 13:02 gdelavald

I'm not sure if Electron already sets those properties, but you could try adding that xml to the build folder, so it gets added to the bundle. If that doesn't work I would look into the windows electron packager to check if there is anywhere I could add that property.

gdelavald avatar Feb 16 '18 13:02 gdelavald

I just dig into it, try to create a successful build, then I send a pr...

mdesign83 avatar Feb 16 '18 13:02 mdesign83

It's not that easy.. it should be supported by electron: https://github.com/itchio/itch/issues/649

mdesign83 avatar Feb 16 '18 14:02 mdesign83