Rocket.Chat.Electron icon indicating copy to clipboard operation
Rocket.Chat.Electron copied to clipboard

Allow use of png for server list icon

Open geekgonecrazy opened this issue 6 years ago • 10 comments

Currently limited to svg. It should take png as well

My Setup

  • Operating System: All
  • App Version: 2.9.0
  • [x] I have tested with the latest version
  • [x] I can simulate the issue easily

Description

If you use png server icon in server list is default icon

Current Behavior

If you use png server icon in server list is default icon

Expected Behavior

It should show the icon uploaded on the server into the logo asset

geekgonecrazy avatar Sep 25 '17 20:09 geekgonecrazy

Hey there! I can give this a shot.

pepkaro avatar Oct 06 '17 03:10 pepkaro

@pepkaro Awesome, if you need any help make sure to hit #desktop on open.rocket.chat to find us.

gdelavald avatar Oct 06 '17 11:10 gdelavald

@pepkaro you working on this? otherwise, I'd like to give this a shot.

abhishek71994 avatar Oct 09 '17 21:10 abhishek71994

Please go for it! I got pulled into other tasks this weekend and haven't started.

pepkaro avatar Oct 10 '17 21:10 pepkaro

if you need any help make sure to hit #desktop on open.rocket.chat to find us.

j-kon avatar Oct 29 '17 19:10 j-kon

@gdelavald please review #8735

james007aonderson avatar Oct 31 '17 17:10 james007aonderson

@gdelavald is this issue still open? I would like to work on it.

Hitansh-Shah avatar Sep 23 '21 09:09 Hitansh-Shah

@gdelavald is this issue still open, I would like to give it a shot.

Sourav12061999 avatar Mar 23 '23 13:03 Sourav12061999

@jeanfbrito, I am working on this one.

I'll update you with the progress shortly. Thanks

preeesha avatar Feb 08 '24 13:02 preeesha

It has already been fixed. Here's a demo video:

2024-02-09-19-18-23

@jeanfbrito I would recommend closing this issue.

preeesha avatar Feb 09 '24 13:02 preeesha